reywood / bitbucket-pr-review Goto Github PK

When opening a large pull request, some files are not loaded.
There is a button "Load all failed diffs" added by Redefined Bitbucket.
After loading all failed files, they all are displayed as unreviewed.
When a new change is detected in PR, and the notification "Pull request updated" in the bottom-right corned appears, all files become displayed correctly.

I was checking out the stats for this extension on the Firefox Add-ons store and noticed that we have some international users. I thought it'd be nice if they could use this extension in their native language. If anyone is fluent (or at least semi-fluent) in a language other than English, I'd greatly appreciate your help with translations.

The following languages appear in the Firefox stats, so they are a good place to start:

• French (fr)
• German (de)
• Polish (pl)
• Russian (ru)
• Spanish (es)
• Turkish (tr)

To add a new language, create a new directory under the _locales directory with the locale code as the name (e.g. fr for French, de for German, etc). Then, copy the messages.json file from the en directory and modify the message values with the correct translation. For example, if you were creating a French translation, your new file would be located at _locales/fr/messages.json. You can remove the description fields from this new file as they are not needed.

You can find more info about how browser extension internationalization works here and here.

When viewing your list of pull requests, would it be possible to show which ones you are done reviewing? Sometimes we leave comments that need some action taken and we don't want to decline or approve the review, but we also want to see which pull requests in our list have been reviewed and which haven't.

This could be done by checking if all the files are reviewed, or by adding a separate "Done Reviewing" button at the pull request level.

When reviewing, you can have some conversations that remain in the PR because the related update is not on the specific line you commented on, or it is on the file itself.

It would be nice to have the ability to mark a conversation as done / completed.

This would hide the comment and add a small (X) label (X being the number of hidden comments in the hidden conversation). Clicking the (X) would restore / unhide the conversation.

• Files with .sql extension spaces in their file paths don't collapse when the Done Reviewing button is pressed

It would be nice if this plugin integrates with "Bitbucket Diff Tree" plugin such that marking a file as "Done Reviewed" or removing the "reviewed" in one plugin updates the other.

https://chrome.google.com/webstore/detail/bitbucket-diff-tree/pgpjdkejablgneeocagbncanfihkebpf/support

Please, give Firefox users the pleasure to use your work as well!

Please see the call stack of the exception while clicking the "Done Reviewing" button.

I use a lot the ignore whitespaces option (add "?w=1" to PR url - eg: /difff?w=1), but when I do this, pr review extension stops working.
I believe there may be a url filter on the extension preventing this.
Is it possible to fix this?
Thanks!

When a pull request is particularly large, some files aren't loaded and instead show the message "Oops! You've got a lot of code in this diff and it couldn't load with the page. Click here to give it another chance." Then when you click to load the file, the Done Reviewing button is not present for that file.

Hi!

Just installed your plugin on Chrome latest and got the following issue:

Uncaught (in promise) TypeError: Cannot read property 'local' of undefined
at Promise (dataStore.js:57)
at new Promise ()
at Function.[set] (dataStore.js:56)
at Function.setReviewed (dataStore.js:14)
at FileDiff.setReviewed (fileDiff.js:50)
at
Promise @ dataStore.js:57
[set] @ dataStore.js:56
setReviewed @ dataStore.js:14
setReviewed @ fileDiff.js:50
async function (async)
setReviewed @ fileDiff.js:48
[handleButtonClick] @ fileDiff.js:95
btn.addEventListener @ fileDiff.js:68

Any hint as to what I should do to make it work?

Bitbucket appear to have changed the class assigned to the author of a comment to be author-name instead of simply author. This breaks hash.js on both lines 42 and 87.

I often scroll through a file to the bottom, and then have to scroll all the way up again to mark it as done. This gets tedious for long files. Could the button be moved to below the file? Or duplicated there?

I try to get this extension working into my bit bucket server. But the content_scripts match is for only bitbucket.org servers.
Have you an Idea if it is possible to add this into a custom bit bucket server? Thanks

When a pull request is very large, scrolling through it is very slow and laggy. This problem does not go away even when most of the files are collapsed.

This browser extension stopped working when I switched to the new PR review experience.

Microsoft Edge Version 96.0.1054.34 (Official build) (64-bit)
BitBucket Pull Request Review Helper Version1.7.1

Using against bitbucket.org pull request. Any ideas?

Below is where the console log comes from in init.js

function isDiffTabActive() {
    const tabMenu = document.querySelector('.pr-tab-links');
    if (!tabMenu) {
        console.log('tab menu not found');
        return false;
    }
    const activeTab = tabMenu.querySelector('.active-tab [data-tab-link-id]');
    return !!activeTab && activeTab.dataset.tabLinkId === 'diff';
}

In the diff view, your plugin helps see which file was reviewed. It would be nice to have the commits whose files have been been "Done reviewing" marked as "Done reviewing" too.
Also the other way around: allow the user to mark a commit as "Done reviewing", which would in turn update the Diff view.

I manually loaded this plugin into firefox and it seems to work fine. Would be nice to be able to get it from the Firefox addons page: https://addons.mozilla.org/en-US/firefox/