reysand / ft_ls

The ls implementation

Hi there, I'm Andrey! 👋

About Me

• 🔭 I’m currently working on Files
• 🎓 I'm currently studying Computer Science at the MTUCI and at the School 21.
• 🌱 I’m currently learning Computational Thinking with Beginning C Programming

Tech Stack

> man reysand

  OS:     Arch Linux
  Shell:  Zsh
  VCS:    Git
  Editor: Vim
  Stack:  C/C++, Java, SQL, Docker

> █

---

GitHub Analytics

ft_ls's Issues

Norm

Norme: include/ft_ls.h

1. Error (line 52): line has 92 characters
   

   ft_ls/include/ft_ls.h

   Line 52 in fe4054c

   int ft_ls(char *name, t_file **file, t_option *option, int i, int ret);

Norme: src/ft_ls.c

1. Error (line 55): ft_ls have 5 parameters
   

   ft_ls/src/ft_ls.c

   Line 55 in fe4054c

   int ft_ls(char *name, t_file **file, t_option *option, int i, int ret)

2. Error (line 55): function ft_ls has 29 lines
   

   ft_ls/src/ft_ls.c

   Lines 55 to 86 in fe4054c

   	int ft_ls(char *name, t_file **file, t_option *option, int i, int ret)
   	{
   	t_dirent *entry;
   	DIR *dir;
   	if (!(dir = opendir(name)))
   	{
   	if (errno == ENOTDIR)
   	{
   	ft_printf("%s\n", name);
   	return (EXIT_SUCCESS);
   	}
   	else
   	{
   	ft_printf_fd(STDERR_FILENO, ERR_MSG, name, strerror(errno));
   	return (EXIT_FAILURE);
   	}
   	}
   	if (i > 1 && ret == EXIT_SUCCESS)
   	ft_printf("\n");
   	if (i > 1)
   	ft_printf("%s:\n", name);
   	while ((entry = readdir(dir)))
   	{
   	if (option->dot_files)
   	get_info(&file, entry);
   	else if ((entry->d_name)[0] != '.')
   	get_info(&file, entry);
   	}
   	closedir(dir);
   	return (EXIT_SUCCESS);
   	}

Norme: src/main.c

1. Error (line 37): function args_handler has 36 lines
   

   ft_ls/src/main.c

   Lines 37 to 75 in fe4054c

   	int args_handler(char **files, t_args *args, t_option *option)
   	{
   	t_file *file_info;
   	int i;
   	int ret;
   	i = 0;
   	ret = EXIT_SUCCESS;
   	file_info = NULL;
   	while (i < args->files_c)
   	{
   	if (ft_ls(files[i], &file_info, option, i, ret))
   	ret = EXIT_FAILURE;
   	/*
   	** Needed add to list of file_info
   	*/
   	/*
   	if (file_info)
   	{
   	if (i >= 0)
   	{
   	if (ret == EXIT_SUCCESS && i > 0 && i < args->files_c)
   	ft_printf("\n");
   	ft_printf("%s:\n", files[i]);
   	}
   	get_ascii_sort(&file_info);
   	print_list(file_info);
   	*/free_list(file_info);/*
   	file_info = NULL;
   	}
   	*/
   	++i;
   	}
   	free_matrix(files, args->files_c);
   	ft_printf_fd(STDERR_FILENO, "\nOptions[%s]: %d %d %d %d %d\n", OPTIONS, \
   	option->recursive_read, option->dot_files, option->long_format, \
   	option->reverse_order, option->time_sort);
   	return (ret);
   	}

2. Error (line 50): bad indentation
   

   ft_ls/src/main.c

   Line 50 in fe4054c

   /*

3. Error (line 50): comment not well formatted
   

   ft_ls/src/main.c

   Line 50 in fe4054c

   /*

4. Error (line 50): comment not well placed
   

   ft_ls/src/main.c

   Line 50 in fe4054c

   /*

5. Error (line 53): bad indentation
   

   ft_ls/src/main.c

   Line 53 in fe4054c

   /*

6. Error (line 53): comment not well formatted
   

   ft_ls/src/main.c

   Line 53 in fe4054c

   /*

7. Error (line 53): comment not well placed
   

   ft_ls/src/main.c

   Line 53 in fe4054c

   /*

8. Error (line 64): bad indentation
   

   ft_ls/src/main.c

   Line 64 in fe4054c

   */free_list(file_info);/*

9. Error (line 64): comment not well formatted
   

   ft_ls/src/main.c

   Line 64 in fe4054c

   */free_list(file_info);/*

10. Error (line 64): comment not well placed
    

    ft_ls/src/main.c

    Line 64 in fe4054c

    */free_list(file_info);/*

option -a

option -R

Algorithms

Bad algorithm in the get_ascii_sorted function

ft_ls/src/sorting.c

Lines 97 to 124 in bf9b147

	void get_ascii_sorted(t_file **head)
	{
	t_file *list;
	t_file **first;
	t_file **second;
	list = *head;
	first = &(*head);
	second = &(*first)->next;
	while ((*first)->next)
	{
	ft_printf_fd(STDERR_FILENO, "%s ", (*first)->name);
	ft_printf_fd(STDERR_FILENO, "%s\n", (*second)->name);
	if (ft_strcmp((*first)->name, (*second)->name) > 0)
	{
	ft_printf_fd(STDERR_FILENO, "NEED_SWAP\t");
	*first = (*first)->next;
	ft_printf_fd(STDERR_FILENO, "%s ", (*first)->name);
	ft_printf_fd(STDERR_FILENO, "%s\n", (*second)->name);
	ft_printf_fd(STDERR_FILENO, "---open---\n");
	ft_printf_fd(STDERR_FILENO, "%s ", (*first)->next->name);
	ft_printf_fd(STDERR_FILENO, "%s\n", (*second)->next->name);
	ft_printf_fd(STDERR_FILENO, "---close---\n");
	}
	first = &(*first)->next;
	second = &(*second)->next;
	}
	}

option -r

option -l

option -t