reviewable / appengine-remove-action

Action to remove versions of deployed App Engine apps over the set limit

Reviewable

This is the support hub for Reviewable, with an user guide and open issue tracker. There's also a chatroom and you can email us directly.

For the lawyers (ohai!), here are the open source server dependencies and client dependencies that Reviewable makes use of.

appengine-remove-action's Issues

Usage example still refers to v2 specifically

Slight issue I came across was that the version in the documentation is specifically set at v2 (uses: Reviewable/appengine-remove-action@v2). This was a little problematic for me as the fix for service_name was added in v2.1.1

Upgrade to Node.js 16.x

GitHub has deprecated Node 12.x for actions. This action needs to be updated to use Node 16.x.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Issues with this on Flex

I switched to flex env and this doesnt work anymore, service account has app engine admin and deployer privs

ABORTED: Cannot operate on ...../services/default/versions/20221020t065906 because an operation is already in progress for .../services/default/versions/20221020t065906 by 3873bdc6-41c8-47f8-8ad4-4206815a9807.

yaml

    - name: Build
      run: npm install -f && npm run build   
      working-directory: server            

    - uses: 'google-github-actions/auth@v0'
      with:
        workload_identity_provider: 'WIP'
        service_account: 'xxxx.gserviceaccount.com'

    - id: 'deploy'
      name: 'deploy'
      uses: 'google-github-actions/deploy-appengine@v0'
      with:
        deliverables: 'be/app.yaml'
        project_id: 'projectID'
        promote: true

    - name: 'show output'
      run: 'echo ${{ steps.deploy.outputs.url }}'
      
    - id: remove
      name: 'Remove old versions'    
      uses: Reviewable/[email protected]
      with:
        limit: 0

    - id: test
      name: 'Remove old versions OUTPUTS'       
      run: |
        echo "${{ steps.remove.outputs.versions_deleted }}"
        echo "${{ steps.remove.total_deleted }}"      

feature request: remove specific version

Im using this action perfectly. But for closing of pr versions we know the version. Is it possible to also pass a specific version and then just remove that version?

And maybe instead of a max number, also an optional max of days :) haha, if i understand how to run it locally i can propose a PR?

Broken for versions > 2.1.2

When using the following configuration it fails to delete the versions:

      - name: 'Remove old versions'
        uses: Reviewable/[email protected]
        with:
          limit: 10
          apply_limit_after_days: 14
          service_name: api