returnkirbo / lethal-company-modpack

windows powershell script for installing lethal company mods

hello!

you might know me for what i do online: i do work related to cybersecurity

you can find more about me at: https://kirbo.zip

have a good day!

         

lethal-company-modpack's Issues

Thunderstore Modpack Support

Hi!

First off, this is a nice improvement to my scripts, thanks for releasing it to the community.

Anyhow, this is a request to support thunderstore modpacks - they can be exported to a code, why not let your script take these modpack codes as an argument?

Soft Security Issue

There is a security issue here, you can replace the script without changing the url.

There are two good options to fix it:

1. Don't do publishes, instead advertise your url using the direct github link. e.g. https://raw.githubusercontent.com/returnkirbo/Lethal-Company-Modpack/ef6d80b6461762d4fad168332ead5e733a6af81e/InstallScript.ps1

2. Sign your scripts before publishing.
   The second option means you have a 'base' script that is commit-locked, this script downloads the latest publish, and checks if you have signed it using your private key. This enables you to auto-update in the future without as many security concerns.

Full disclaimer, I haven't done this yet, simply because I didn't plan on maintaining my scripts long term. It was pretty much just to reduce the modding support channels in the early days of lc modding.