respitesage / saline Goto Github PK

Currently, Saturating can't be used directly as the argument of Number arithmetic operations. You have to use Saturating#value. That seems non-ideal, so I should implement patches on numeric types to allow operations with Saturating on the right-hand side.

Currently Saturating doesn't override division operators (they should still work, just without saturating arithmetic), but division by values between 0 and 1 could cause overflow. I expect the addition to match the existing code fairly well.

Currently, Saturating can only perform operations with Number types and Saturating objects with the same generic type. Instead, you should be able to add Saturating(T) with Saturating(U) for any T and U (and of course the same goes for other operations). In theory, this should be as easy as adding forall U and updating method definitions correspondingly.

It would be nice to have saturating arithmetic with saturation boundaries wherever you want. If, for example, you wanted to saturate at a much lower upper boundary than existing types (e.g. 30) or had some weird desired lower and upper boundaries (e.g. [32..210]), it would be nice to have types that would just act how you wanted instead of needing checks everywhere.

So far, I'm thinking that this could be accomplished by having another struct or class like so
Clamped(T,B,U) where T is the value type, like right now, B is a numeric lower bound, and U is a numeric upper bound. In theory, you could probably implement the existing Saturating struct as one of these new types, but structs can't inherit from non-abstract structs... It's worth thinking about.