replicatedhq / krew-plugin-template Goto Github PK

While reviewing kubernetes-sigs/krew-index#365, I noticed that this template got out of sync with what we recommend in https://github.com/kubernetes-sigs/krew/blob/master/docs/DEVELOPER_GUIDE.md#writing-a-plugin-manifest. In particular, it does not install a LICENSE file, which we now require.

Besides, I'm wondering if you could include the descriptive comments for the manifest fields in your template. Of course, these should be removed before submitting the template, but it could help plugin authors to get started. WDYT?

uri: https://github.com/{{ .Owner }}/{{ .Repo }}/releases/download/v0.1.0/{{ .PluginName }}_0.1.0_linux_amd64-0.1.0.tar.gz

several issues

1. 0.1.0 appears 3 times in url
2. consider using v0.1.0 every time you refer to the version

I am trying this out and the make setup seems broken:

$ make setup
make -C setup
make[1]: Entering directory '/home/akrzos/go/src/github.com/akrzos/k8sCube/setup'
go run ./...
go: github.com/minio/[email protected] requires
	github.com/minio/gokrb5/[email protected]: reading github.com/minio/gokrb5/go.mod at revision v7.2.5: unknown revision v7.2.5
make[1]: *** [Makefile:6: all] Error 1
make[1]: Leaving directory '/home/akrzos/go/src/github.com/akrzos/k8sCube/setup'
make: *** [Makefile:29: setup] Error 2

After starting a new repo with this template I run make setup. but there is an issue with the GitHub token for the goreleaser. I'm not sure if this a requirement of my system that I'm missing, as I haven't worked with GitHub actions before. I created a Personal Access Token and exported its value as the GITHUB_TOKEN environment variable locally but that didn't change the error.

This is the output from running make setup:
emphasis on template: release.yml:22: function "secrets" not defined

$ make setup 
make -C setup
make[1]: Entering directory '/home/brian/Projects/kubectl-viz/setup'
go run ./...
GitHub Organization or Usernamebrianrudolf
GitHub Repo Namekubectl-viz
Plugin Namekubectl-viz
Updating README
Updating sample code with names
template: release.yml:22: function "secrets" not defined
exit status 1
make[1]: *** [Makefile:6: all] Error 1
make[1]: Leaving directory '/home/brian/Projects/kubectl-viz/setup'
make: *** [Makefile:29: setup] Error 2

I think this is more of a GitHub secrets error I'm running into but I'm hoping someone here can point me in the right direction and we can edit the README to add this as a prerequisite for this template.

An example of a working action is: https://github.com/marccampbell/kubectl-alias/blob/3a7656fe2996d0e6ac34d9c096ac18787e076349/.github/workflows/build-test-deploy.yaml

The current action is HCL based and does not work.

(The above link is not valid, a slightly more complex one is at https://github.com/replicatedhq/kots/blob/master/.github/workflows/deploy.yaml)