rentadronecl / web-api Goto Github PK

Rubric Open Source (Justin Flory)

Evaluation = RED
Title: Pull Request Workflow
Requirement 3: Regular Use in Development
Actual: Pull requests are not used often.
Other Actions: Apply to all repositories.
More Info: https://help.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository

Create Documentation for each of the project repositories: There must be a section for Developers and another section for Users. An appropriate application must be used for Open Source documentation.

Meet all de Rubric Requirements. See here: https://docs.google.com/spreadsheets/d/1c-HQSBqRTmBZbPDUoLdxKy6OaiAg05004DEcrwESd0o/edit#gid=0

Rubric Open Source (Justin Flory)

• Evaluation = RED
• Title: Contributing Guidelines
• Requirement 3: Guidelines for Filiing an Issue
• Actual: No one can follow the guide, or the guide doesn't exist.
• Other actions: Resolve for all repositories
• More info: https://help.github.com/en/github/building-a-strong-community/configuring-issue-templates-for-your-repository

Rubric Open Source (Justin Flory)

• Evaluation = YELLOW
• Title: Contributing Guidelines
• Requirement 1: Quality of Writing
• Grammatical, technical, and semantic errors are noticable. May be difficult for non-native speakers to understand.
• Other actions: Resolve to all repositories

Some of the reason:

• Auto documentation
• Async/Await support
• Built-in validation and serialization

Few grammatical, technical, and semantic errors. Easy to understand for a non-native speaker.

uvicorn run:app --reload
INFO: Uvicorn running on http://127.0.0.1:8000 (Press CTRL+C to quit)
INFO: Started reloader process [36216]
INFO: Could not open font file /usr/share/fonts/truetype/noto/NotoColorEmoji.ttf: In FT2Font: Could not set the fontsize
INFO: generated new fontManager
Process SpawnProcess-1:
Traceback (most recent call last):
File "/usr/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
self.run()
File "/usr/lib/python3.8/multiprocessing/process.py", line 108, in run
self._target(*self._args, **self._kwargs)
File "/usr/lib/python3/dist-packages/uvicorn/subprocess.py", line 61, in subprocess_started
target(sockets=sockets)
File "/usr/lib/python3/dist-packages/uvicorn/main.py", line 382, in run
loop.run_until_complete(self.serve(sockets=sockets))
File "uvloop/loop.pyx", line 1501, in uvloop.loop.Loop.run_until_complete
File "/usr/lib/python3/dist-packages/uvicorn/main.py", line 389, in serve
config.load()
File "/usr/lib/python3/dist-packages/uvicorn/config.py", line 288, in load
self.loaded_app = import_from_string(self.app)
File "/usr/lib/python3/dist-packages/uvicorn/importer.py", line 20, in import_from_string
module = importlib.import_module(module_str)
File "/usr/lib/python3.8/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1014, in _gcd_import
File "", line 991, in _find_and_load
File "", line 975, in _find_and_load_unlocked
File "", line 671, in _load_unlocked
File "", line 848, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/adjebbar/WorkDir/Web-API/./run.py", line 1, in
from app import create_app
File "/home/adjebbar/WorkDir/Web-API/./app/init.py", line 5, in
from app.http.controllers.api.PredictionController import PredictionController
File "/home/adjebbar/WorkDir/Web-API/./app/http/controllers/api/PredictionController.py", line 3, in
from skimage import io
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/init.py", line 15, in
reset_plugins()
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/manage_plugins.py", line 91, in reset_plugins
_load_preferred_plugins()
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/manage_plugins.py", line 71, in _load_preferred_plugins
_set_plugin(p_type, preferred_plugins['all'])
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/manage_plugins.py", line 83, in _set_plugin
use_plugin(plugin, kind=plugin_type)
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/manage_plugins.py", line 254, in use_plugin
_load(name)
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/manage_plugins.py", line 297, in _load
plugin_module = import('skimage.io._plugins.' + modname,
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/skimage/io/_plugins/matplotlib_plugin.py", line 3, in
from mpl_toolkits.axes_grid1 import make_axes_locatable
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/mpl_toolkits/axes_grid1/init.py", line 3, in
from .axes_grid import Grid, ImageGrid, AxesGrid
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/mpl_toolkits/axes_grid1/axes_grid.py", line 22, in
class CbarAxesBase:
File "/home/adjebbar/WorkDir/Web-API/myenv/lib/python3.8/site-packages/mpl_toolkits/axes_grid1/axes_grid.py", line 62, in CbarAxesBase
cbid = cbook._deprecate_privatize_attribute(
AttributeError: module 'matplotlib.cbook' has no attribute '_deprecate_privatize_attribute'

Rubric Open Source (Justin Flory)

EVALUATION: Yellow
SUBJECT: Contributing Guidelines - Requirement 3: Guidelines for Filing an Issue
DETAIL: Guidelines may not fit many issues being filed but overall provide a unitary theme to issues submitted.
POSSIBLE SOLUTION: Include step-by-step instructions on how to open an issue

Verify that our current Project Board meets all the requirements of the rubric

See: https://docs.google.com/spreadsheets/d/1c-HQSBqRTmBZbPDUoLdxKy6OaiAg05004DEcrwESd0o/edit#gid=0

Rubric Open Source (Justin Flory)

EVALUATION: Yellow
SUBJECT: Developer Documentation - Requirement 4: Project Hierarchy Explaination
DETAIL: The organization of the repos is explained, without visuals. Each component may or may not get a proper explaination.
POSSIBLE SOLUTION: Include visuals of the repositories and own explanations for each repo for dummies

Rubric Open Source (Justin Flory)

EVALUATION: Red
SUBJECT: READMEs - Requirement 6: Mission Statement
DETAIL: README explains what project is does, but it is not clear how connected this repo is with your other work.
POSSIBLE SOLUTION: Include in all reports Title, Mission, Goals, Roadmaps and Jobs in Progress. (Homologate with the To Do List of the model-definition repo)