Comments (12)
I'd like to thank you for all the work that you've done for this, and for the atom extension before this. I use it myself, and appreciate everything you've done.
I'd like, if possible, to transfer the extension to the @renpy organization, so that I can at least keep the basic syntax highlighting updated in sync with Ren'Py - and if we can improve the grammar, add full intellisense, and so on, that would be wonderful. (But probably beyond what i'd be good at - I'd love it if @duckdoom4 and others could help with that.)
Again, thank you for everything you've done - and for being willing to look out for the project like this.
from vscode-language-renpy.
There isn't really a Ren'Py parser, to be honest - at least, not one that conforms to grammar rules. It's pretty close to an LL(k) parser, but there are several places where the Ren'Py parser simply passes everything to the end of the line, or everything in parenthesis, or everything in a block to Python.
So I don't think copying the parser is doable, unless we can shell out to Python in certain places.
I can try and review the code and keep the automation working, but I'm not up on VS code or the automation. Hopefully I can learn.
from vscode-language-renpy.
Thanks for the kind words, hope you're doing well 🙏
I would love to help again when I find the time. Currently I have work and other personal projects that take priority, but this project is definitely still on my mind. Still have plenty of ideas to implement and continue with the full intellisense like features.
I do have to say that it's a lot of work for just me, so I would welcome any help I can get with open arms
from vscode-language-renpy.
Okay, let's move the repo hosting over to @renpy.
What I'm thinking is publishing a new version now, and modifying the Ren'Py extensions system so it installs the new version - that will end automatic installs. Then in Ren'Py 8.3, there will be a change to the launcher that will uninstall the old and install the new extension (can extensions conflict?).
from vscode-language-renpy.
Everything is going well, thanks!
I think it's a good idea to transfer the repository to @renpy. Maybe it will attract new contributors. If @renpy were to publish the extension, we could deprecate the current one in its favor.
Also, I want to continue helping and contributing as soon as I've some free time 😄
from vscode-language-renpy.
I think that makes sense. Do you want to transfer the repo, or should I fork it?
I can probably also have the launcher handle the migration to the new extension, and I would also like to immediately update the syntax to include new keywords.
And I'd be happy if you keep helping - it's been incredibly valuable to have you handling the extension, so I can focus on the engine.
from vscode-language-renpy.
I can transfer it 👍 Just let me know and I'll do it.
Then it will be necessary to publish a new version of the extension (taking the opportunity to correct the typo in the name languague-renpy 🤣), once published I'll be able to request that the extension I published be deprecated in favor of the new one.
from vscode-language-renpy.
Done! ✨
from vscode-language-renpy.
You can add the VS API token in the secrets (repository configuration) to make the publishing workflow with GitHub Action work. The workflow is triggered by adding a tag, for example, v2.3.0 (v2.4.0-pre-release for previews). More information:
@duckdoom4 had collaborator permissions on the repository.
from vscode-language-renpy.
Would be awesome if we could still have that, but I completely understand if you'd want all commits to be reviewed before they are merged even on develop
from vscode-language-renpy.
Yep, of course, code reviews should always be a required step before integrating new code (we also have automation to check style and code).
from vscode-language-renpy.
So now this is 'officially' part of renpy, maybe we should check if we can automate some tasks. I remember we started working on some grammar definitions and my intention was to use those to generate the parser rules and AST nodes. That way we would only need to maintain one source. (And probably fix the occasional bugs).
Another option is to use the original renpy parser, but problem with that is the language barrier. I'm not sure how easy it is to execute python code from the extension + the need to output the entire AST state and rebuild it on the extension side.
If anything it might be easier to simply copy the exact implementation and convert it to js. (Which I wasn't comfortable with before, but now it's part of renpy that's no longer an issue :p)
from vscode-language-renpy.
Related Issues (20)
- Still some formating issues in 2.3.1 HOT 17
- To all Ren'Py users! We need your help! - Full Ren'Py grammar definition for 'intellisense' HOT 15
- [BUG] - Extension enters a lockup state and blocks all other extensions from loading HOT 9
- [Bug] - Extension alters workspace.settings.json with incorrect settings HOT 7
- [Feature] Support for new _ren.py format used in Renpy 8 HOT 6
- [Bug] - Extension alters workspace.settings.json with incorrect settings (with example) HOT 1
- [Feature] - Use standard denotation for deprecated functions + offer alternatives HOT 2
- Error: Illegal argument: character must be non-negative HOT 2
- Diagnostics mistakes on not-defaulted variables
- Slow Performance (Intellisense primarily) HOT 14
- Wrong float highlight when having digits both before and after the dot HOT 1
- Color picker breaks when rpy file becomes invalid syntax and doesn't recover HOT 3
- Ar
- (Diagnostics) consider label parameters as global variables
- H
- "Go to Definition" doesn't work on Python functions in ren'py
- Run: Renpy: Run project command doesn't support space in project path HOT 2
- Bug, The extension doesn't work at all, stuck on Loading Ren'py static data HOT 4
- Windows: Renpy executable location doesn't work when Running unless the backslashes are escaped HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-language-renpy.