renovosolutions / cdk-library-managed-instance-role Goto Github PK

The following need to be true:

• If domain join is enabled both domain join and ssm are enabled regardless of ssm setting
• If ssm is enabled then ssm should be enabled, but have no effect on domain join setting
• If either is undefined it will default to true and follow the cases above

Is your feature request related to a problem? Please describe.
When consuming the resulting construct for an ec2.Instance construct you must apply an override to use the role directly. This orphans the default instance profile as well as makes using this construct a bit hacky.

Describe the solution you'd like
There is still a valid case for profile creation, but it should be optionally disabled. In addition the construct should expose the role construct directly so it can be consumed easily for instance creation or otherwise.

Describe alternatives you've considered
None.

Additional context

Proposed implementation
Add properties. Make profile creation optional with a boolean prop.

Any currently forseeable downsides to this approach
No. This is completely compatible with prior usage.