rendermani / ascio-whmcs-plugin Goto Github PK

There are very common names, and to avoid conflicts with WHMCS and other modules I will add namespaces.

Hello, I was using the old Plugin, but now due to a change in some plans, I tried the new one. I have some problems and also some questions.

1. Is it possible to automatically get Domains/TLDs names from ascio inside WHMCS ( /admin/configdomains.php )?
2. Is it possible to automatically get SSL certificates inside products?

Setting up the newest plugin I get: ( /admin/addonmodules.php?module=ascio )

Addons
An Error Occurred. Please check module coding.

Inside ( admin/configaddonmods.php ) It doesn't show module information:

With some phonenumbers the reformat didn't work.

As asked by whmcs, we have updated the php version on the whmcs itself. Before php 7.4, now php 8.1
With php 8.1 i see few errors. Example:

 private function formatDate($xsDateTime) {
                if($xsDateTime == "0001-01-01T00:00:00") return false;
                $dateTokens = explode("T", $xsDateTime);
                if(count($dateTokens == 2)) {
                    return str_replace("-", "", $dateTokens[0]);
                }
                return false;
        }

here if $dateTokens is not an array, php 8.1 return a fatal error. And is no longer access to the domain page.
I have added a control over that array in order to temporary fix.
Please can you check if the rest of the implementation is php 8.1 ready?

ty

Dear,

today we have updated to the latest whmcs (8.10) and here we see a conflict with your ascio-whmcs plugin, like this (this is the output of the cron script run in debug mode):

Domain Status Synchronisation
PHP Fatal error:  Cannot declare class it, because the name is already in use in /var/www/clients/client4/web130/web/modules/registrars/ascio/tlds/it/it.php on line 2

Fatal error: Cannot declare class it, because the name is already in use in /var/www/clients/client4/web130/web/modules/registrars/ascio/tlds/it/it.php on line 2
[WHMCS Application] ERROR: Whoops\Exception\ErrorException: Cannot declare class it, because the name is already in use in /var/www/clients/client4/web130/web/modules/registrars/ascio/tlds/it/it.php:2 Stack trace: #0 /var/www/clients/client4/web130/web/vendor/whmcs/whmcs-foundation/lib/Utility/Error/Run.php(0): WHMCS\Utility\Error\Run->handleError() #1 [internal function]: WHMCS\Utility\Error\Run->handleShutdown() #2 {main} {"exception":"[object] (Whoops\\Exception\\ErrorException(code: 64): Cannot declare class it, because the name is already in use at /var/www/clients/client4/web130/web/modules/registrars/ascio/tlds/it/it.php:2)"} []
Whoops\Exception\ErrorException: Cannot declare class it, because the name is already in use in /var/www/clients/client4/web130/web/modules/registrars/ascio/tlds/it/it.php:2

#0 /var/www/clients/client4/web130/web/vendor/whmcs/whmcs-foundation/lib/Utility/Error/Run.php(0): WHMCS\Utility\Error\Run->handleError()
#1 [internal function]: WHMCS\Utility\Error\Run->handleShutdown()
#2 {main}

in my opinion this is because you don't use namespace on your code, so that a it class conflict with an already present on whmcs itself another part of the plugin.
Please can you give it a check asap?

thank you

Why are you using the API externally instead of using internal calls?
Internal calls don't even need auth, so major win in security and configuration among other things.

Are you open to a PR for this? If so I will contribute with it :)

I've noticed when running the WHMCS domainsync.php script that the 1st ASCIO domain always fails with ERROR: domain not found.

Hello ,

I want to ask about is there a way to implement such of options like : privacyProtection, theftProtection
If yes is it possible to post some examples ?

Thanks

Hi there,

I'm guessing that the libphonenumber-for-PHP subdirectory was created to solve the same problem that I have, namely that WHMCS doesn't present "clean" e164-formatted numbers required by EPP.

I'd like to avoid reinventing the wheel, and reuse your code in the CentralNic WHMCS module. There are a couple of things preventing that though:

1. the licensing status of this repository is unclear, I don't see a license file or anything in the README
2. would it be possible to create a separate Git repo for the libphonenumber-for-PHP subdirectory that I can add as a submodule?

Thanks!

Is it possible to add also on your main branch the message id of the polling on the whmcs logs?
I did something like this:

Tools::log("DomainId: " . $domainId." not found in the WHMCS-Database: " .$order->order->Type. ", Domain: ".$domainName.", Order-Status: ".$orderStatus."\n ".$errors.", Message-id: ".$messageId);

on row 253 of lib/Request.php

in order to see, faster, what is the message polling id that create problem. If any.
ty

After the upgrade, I get this error:

[php7:notice] [pid 32755] [WHMCS Application] ERROR: ArgumentCountError: Too few arguments to function Request::searchDomain(), 0 passed in /public/modules/registrars/ascio/ascio.php on line 52 and exactly 1 expected in /public/modules/registrars/ascio/lib/Request.php:134 Stack trace: #0 /public/modules/registrars/ascio/ascio.php(52): Request->searchDomain() #1 /public/vendor/whmcs/whmcs-foundation/lib/Module/AbstractModule.php(0): ascio_GetNameservers(Array) #2 /public/vendor/whmcs/whmcs-foundation/lib/Module/Registrar.php(0): WHMCS\Module\AbstractModule->call('GetNameservers', Array) #3 /public/vendor/whmcs/whmcs-foundation/lib/Domains.php(0): WHMCS\Module\Registrar->call('GetNameservers', Array) #4 /public/backend/clientsdomains.php(0): WHMCS\Domains->moduleCall('GetNameservers') #5 {main} {"exception":"[object] (ArgumentCountError(code: 0): Too few arguments to function Request::searchDomain(), 0 passed in /public/modules/registrars/ascio/ascio.php on line 52 and exactly 1 expected at /public/modules/registrars/ascio/lib/Request.php:134)"}