remychantenay / slog-otel

Go slog's Handler implementation to ensure correlation with Open-Telemetry spans.

About me

Not much yet.

slog-otel's Issues

for logs/traces on GCP, need to stop writing the event log

Much like the option for NoBaggage, need a way to stop writing the event logs to the traces - this is correlation is done automatically (and views better than a vanilla event) when the logs are fed to GCP's logs as long as the trace_id and span_id are moved up to the OTEL log record by the OTEL collector (i.e. via trace_parser)

trace_id needs to be added regardless of whether a span is recording

The logic for adding the trace_id skips adding trace_id for any non-recording traces, which isn't helpful - if the trace_id is known it should be added.

[Bug] Slices aren't being recorded

Hi,

First of all - wanted to thank you for making a great library. I am reaching out because while using this library, I noticed a small bug. When I have a slice of string or any in an argument, it doesn't get recorded.

Example:

strs := make([]string, 2)
strs = append(strs, "arg1")
strs = append(strs, "arg2")
slog.InfoContext(ctx, "arguments", "strs", strs)

This shows up fine on my log output with the appropriate trace_id and span_id. However, the argument doesn't get recorded with OTel and is missing from the resulting trace. My configuration is the same as the usage example:

slog.SetDefault(slog.New(slogotel.OtelHandler{
    Next: slog.NewJSONHandler(os.Stdout, nil),
}))

First, I thought that this might be a bug on the receiver side, but then I switched to using stdouttrace and still noticed that it isn't getting recorded. If I marshal the array into a JSON string and then log it with slog, it works fine and shows up in the trace. Are you able to replicate this from your end?

Thanks,
Faraz