remram44 / matrix-appservice-gitter-twisted Goto Github PK

I don't know how to close a Twisted web response.

See matrix.py:132:

        if self.stream_response is not None:
            pass  # FIXME: how to close the connection?

When forwarding from Gitter to Matrix, it is possible for the homeserver not to handle requests in order, which can mean the messages are posted out of order. Particularly possible since we do multiple API requests to post (invite, join, post).

Currently, no list of users is obtained from Gitter: a user shows up in the Matrix room when he first speaks, and is never removed.

• Shouldn't invite/join users everytime they speak
• The full list of users should be obtained when the room is created, and virtual users created then
• We should react to the user join/leave events and add/remove virtual users then

It seems that inviting the bot from a federated room doesn't work unless we register it properly with the homeserver beforehand.

This means:

• The bot (usually @gitter) has to fall within the reserved user namespace in the registration file
• The virtual user needs to be created via an API call

The appservice could really create that user itself on the first run. That will probably avoid a lot of headaches down the road.

$ curl -X POST -H 'accept: application/json' \
    -d '{"type": "m.login.application.service", "username": "gitter"}' \
    https://myhomeserver:8448/_matrix/client/r0/register?access_token=xxxxxxxx

Markdown issue, follows on #7

Gitter allows the ![alt](http://image.png) syntax to insert images in messages. Even though I correctly render to <img> in HTML, Riot strips it, only rendering attachments and previews.

I don't know how to fix this. There is just no way to get Riot to render embedded images.

If you are using this bridge but send a message directly from the Gitter website, this message won't appear in your Matrix room at all. This could be fixed by keeping track of the message the bot sends, and forwarding the message from your Gitter user that it didn't send.

That would mean that a gitter_yourname Matrix user would appear, which would be awkward once #1 is fixed.

Right now the room is created empty, although Gitter supports retrieving old messages and Matrix supports injecting them.

Importing the full history is not a good idea, but a limited number of recent messages would be useful.

Markdown posted on Matrix gets posted on Gitter fine, but markdown in Gitter shows up as text in Matrix. I must have missed something in the message format.

Since both Gitter and Matrix support room avatars it would be nice to set gitter room avatar on the matrix side. This would help to distinguish the rooms.

Hello,

Firstly, thanks for your work.

Please could you add support to connect to hipchat?

Thanks again.

Currently you can bridge a room you are not in on Gitter.

Lots of callbacks in there. It would look a lot better with async/await.