remix-run / react-router-website Goto Github PK

          We have an example for this: https://github.com/remix-run/react-router/tree/dev/examples/auth

Originally posted by @timdorr in remix-run/react-router#10206 (comment)

Sorry, not shure is there a bug or stackblitz fault, but

$ vite
failed to load config from /home/projects/mkligxplv.github/vite.config.ts
error when starting dev server:
Error: The package "@esbuild/linux-x64" could not be found, and is needed by esbuild.

on https://stackblitz.com/github/remix-run/react-router/tree/main/examples/auth?file=src%2FApp.tsx

Describe what's incorrect/missing in the documentation

I noticed some misbehavior in the functionality when changing themes in React Router Docs.
The theme is changing back or back and forth between dark/light when you:

1. click on the theme icon and change the theme and then immediately click on the h2 (for example in the Tutorial page heading with the id="data-writes--html-forms") or
2. clicking on the empty space between the main text and the sidebar with the headings

This is checked on both Chrome (Version 118.0.5993.117 ) and Firefox (Version 118.0.5993.117 )

This is the same issue remix-website had

The changes that need to be made should be pretty similar to the fix I added

remix-website's version

Will also want to check the styles and make them similar (docs.css)

What version of React Router are you using?

6.4.3

Steps to Reproduce

• Create a simple react project with react-router 6.4.3
• Call the useLocation hook -> const location = useLocation()
• Hover the useLocation() and a pop-up will appear:

Expected Behavior

Redirecting to the useLocation() docs page

Actual Behavior

Redirecting to 404 page

Edit: All the hooks docs url are wrong. The problem here is that i'm using an old react router version (6.4.3) instead of the main one (6.5.0)

It's complaining about the node:child_process, "Error: Cannot find module 'node:child_process'".

Adding search to reactrouter.com would significantly reduce time spent looking for the correct function / component

I was receiving an error stating "Unexpected use of 'confirm'"

I was able to resolve this by adding window.confirm instead of just confirm

Let's render the changelog file

What version of React Router are you using?

docs

Steps to Reproduce

1. navigate to https://reactrouter.com/
2. click on any link
3. click on go back (browser)

Expected Behavior

should not crash

Actual Behavior

Happens not only to me.

See remix.run for details

• Make lefthand nav sections collapsable
• Make righthand nav nested levels indented

Example: https://reactrouter.com//google.com/
Expectation: 404
Actual: 302 redirects to google.com

This is bad because a malicious actor can send links that look like official reactrouter.com pages but the end users get silently redirected to a possible malicious site owned by the sender

I haven't dug too much into this yet but also see that it affects the main remix.run site too - https://remix.run//google.com/

Depends on #90

http://www.reactrouter.com and https://www.reactrouter.com currently show a 500 error.
Should redirect to https://reactrouter.com instead.

Remix uses DocSearch by Algolia. Might be easiest just to copy this

Describe what's incorrect/missing in the documentation

In this case, the nested route on the list on the right should be either highlighted or underlined.

I have yet to try Remix, but this would be an excellent PR to get my feet wet.

Is anyone working on this?

Describe what's incorrect/missing in the documentation

Describe what's incorrect/missing in the documentation

The right sidebar functionality on the React Router documentation website is not working properly.

Steps to reproduce

1. Visit the React Router documentation website.
2. Navigate to any link within the right sidebar. first navigate works correctly
3. Observe the screen momentarily jumping and then returning to its previous state.
4. Notice that the link in the browser updates correctly, but the content does not reflect the change.
5. Click the same link again, and observe that the functionality works as expected this time.

Video of the bug

System info

• Windows 10
• Chrome Version 122.0.6261.95 (Official Build) (64-bit)

Describe what's incorrect/missing in the documentation

Expected behavior: clicking on links in the right nav of the documentation site should scroll to the anchor on the first click.

Actual behavior: first link clicked in the right nav always works, but all subsequent clicks on different links do not scroll to the anchor, unless you click on them a second time in a row without clicking any other links.

Details:

• Affects chrome (on Windows 10):120.0.6099.110
• Affects Edge (on Windows 10): 120.0.2210.77
• Affects chrome on a mobile device
• Does not affect firefox 121.0

Seems like the edit button in the footer is adding 1 too many "/docs"

Description:

I'd like to propose a feature for the official React Router documentation website. While going through the various examples in the documentation, I noticed that there isn't a straightforward way to copy the code samples.

Feature Description:

It would be extremely helpful if a 'Copy' button could be added to each of the code blocks within the documentation. This button would allow users to instantly copy the code samples to their clipboard, reducing the chance of copying errors and saving time.

Benefits:

• Increased efficiency: This feature would allow developers to easily copy and paste code into their IDE without needing to manually select and copy the code, saving time and effort.
• Reduced error potential: By enabling one-click copying, we can minimize the chance of copying errors that might occur when users manually select code blocks.
• Improved user experience: This feature would make the documentation more user-friendly and increase its utility for developers of all experience levels.

I believe this would be a valuable addition to the React Router documentation, and I'd be happy to discuss it further if needed.