Coder Social home page Coder Social logo

Comments (4)

machour avatar machour commented on September 27, 2024

Also updated UnoCSS's remix example: unocss/unocss#3850

from examples.

imaitland avatar imaitland commented on September 27, 2024

@machour Curious - Why is jokes archived and "won't be touched". The prod build currently fails with:

➜  _official-jokes git:(main) npx prisma migrate deploy
Need to install the following packages:
[email protected]
Ok to proceed? (y) y

Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "dev.db" at "file:./dev.db"

1 migration found in prisma/migrations


No pending migrations to apply.
➜  _official-jokes git:(main) npm start

> start
> remix-serve build

Error: Directory import '/Users/iainland/Projects/remix-palyground/examples/_official-jokes/build' is not supported resolving ES modules imported from /Users/iainland/Projects/remix-palyground/examples/_official-jokes/node_modules/@remix-run/serve/dist/cli.js
Did you mean to import "/Users/iainland/Projects/remix-palyground/examples/_official-jokes/build/index.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:259:11)
    at moduleResolve (node:internal/modules/esm/resolve:933:10)
    at defaultResolve (node:internal/modules/esm/resolve:1157:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:227:38)
    at ModuleLoader.import (node:internal/modules/esm/loader:315:34)
    at defaultImportModuleDynamically (node:internal/modules/esm/utils:194:31)
    at importModuleDynamicallyCallback (node:internal/modules/esm/utils:216:12)
    at reimportServer (/Users/iainland/Projects/remix-palyground/examples/_official-jokes/node_modules/@remix-run/serve/dist/cli.js:86:81)
    ```

from examples.

machour avatar machour commented on September 27, 2024

@imaitland This is a decision made with Brooks over discord, without being aware of the issue you're posting. Thank you for bringing it to our attention 🙏🏼

The idea was that the jokes tutorial was retried from the documentation, and we weren't interested in maintaining a legacy Remix v1 app.

CC'ing @brookslybrand to have a new look at this decision. Maybe we could spend some time fixing the example, or just add a note in its README stating that it's archived, and why.

from examples.

brookslybrand avatar brookslybrand commented on September 27, 2024

@imaitland This is a decision made with Brooks over discord, without being aware of the issue you're posting. Thank you for bringing it to our attention 🙏🏼

The idea was that the jokes tutorial was retried from the documentation, and we weren't interested in maintaining a legacy Remix v1 app.

CC'ing @brookslybrand to have a new look at this decision. Maybe we could spend some time fixing the example, or just add a note in its README stating that it's archived, and why.

Yep, that is correct. Someone is definitely welcome to submit a PR to fix the issue for anyone who still finds the tutorial useful, but since it is not the official tutorial the Remix team is not focused on moving it to v2.

I do like the idea @machour of adding a note to the README about why it is archived

from examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.