sharing-loader-data example choice justification about examples

[machour]

Hey @NicolasCharpentier

Where I would have redirected in the component (client-side) if parent segment does not have the workshop.

In your case, /workshops/nimportequoi would still reply with a 200, and then would redirect client side. This looks really bad for seo, and I could reference a bunch of links with horrid stuff on the url, and they would get indexed by search engines, harming your website reputation 😄

In that regards, it makes sense to always have a test in the $workshopId.tsx route.

Plus, the fact that you send an empty object in the loader looks pointless to me, I believe in many app a single resource won't be that big, so it's OK adding it in a response we already have to send.

Yep, in a real-world app, you wouldn't probably have the parent route load all entities, and the child routes read from that. Every child route would load its own entity in its loader and deal with it's own data. The purpose of the example is to show how to retrieve a parent route data at the component level, so it makes sense to have it that way.

The example is outdated, as we know have useRouteLoaderData which is way more powerful in this particular case. I'm in the process of updating all examples.

Did you give Remix a go?

[machour]

Btw, closing this to tidy up the issue tracker, feel free to hop on our discord server to continue the conversation: https://rmx.as/discord