relequestual / test-json-schema-acceptance

WIP You have been warned

Archived

This repo has been archived in favour of https://github.com/karenetheridge/Test-JSON-Schema-Acceptance

test-json-schema-acceptance's Issues

Use 'draft' in draft number to avoid conflicting with actual versions

If we actually get a v3 of JSON Schema, having an integer as the sole argument of the constructor is going to be confusing and surprising. I would expect one of the following

Test::JSON::Schema::Acceptance->new('draft-04');
Test::JSON::Schema::Acceptance->new( version => 'draft-04' );
Test::JSON::Schema::Acceptance->new({ version => 'draft-04' });

Fix Testers failures

Hooray, CPAN Testers is working again!

That means we can see passes and fails at: http://matrix.cpantesters.org/?dist=Test-JSON-Schema-Acceptance+0.0.2

Looks like a lot of them are failing because JSON isn't a declared dependency. (Some pass by chance, because they've already got it installed).

Some of them (before 5.14) have a different problem.

Update documentation to explain who would and why you would want to use this module

Notes:

There's json-schema, the specification that allows you to define a schema (in json) that you can use to validate json with.

There's the test suite, which came from the same organisation as json-schema, which contains a set of tests (in json) which can be used to confirm that anyone implementing json-schema, does so correctly.

There's JSON::Schema, which is the perl module implemented by someone not from that organisation which implements json-schema the spec.

This module allows other perl modules (for example JSON::Schema) to test that they are json-schema compliant, by running the tests from the official test suite, without having to manually convert them to perl tests

Draft depends on last call to new, not on object

our $draft;

...

sub new {
  my $class = shift;
  $draft = shift || 4;
  return bless {}, $class;
}

...

my $draft_dir = $mod_dir . "/tests/draft$draft/";

Umm....