release-notifier / release-notifier

Source code for the probot GitHub app

release-notifier-bot

A Probot that leaves helpful comments on your pull requests when they land in a release.

This bot is designed for use with projects that are using GitHub Releases and Semantic Versioning.

Install

To get a comment from this bot when a pull request lands in a release for a repo:

1. Go to the Release Notifier Github App page.
2. Click the Configure button.

From here you will be guided through the installation process for adding the release notifier bot to your repo or github org of choice.

License

MIT

release-notifier's Issues

logging

When things don't work, the application logs are a good place to look to help diagnose the problem. Unfortunately I think @yoshuawuyts' nanostate publish event is lost in the ether.

By default, Heroku only retains the last 1500 log lines for an app, so I just set up a Papertrail log drain on the Heroku app that gives us the following:

Log volume per day: 100 MB
Search duration: 7 Days
Archive duration: 365 Days

So.. what kind of logging statements should we add to the app to make for useful debugging sessions? And what LOG_LEVEL should be used? I get that feeling that we'll burn up our allotment too quickly if its set to trace.

cc @gr2m @bkeepers

An in-range update of semver is breaking the build 🚨

Version 5.5.1 of semver was just published.

Branch	Build failing 🚨
Dependency	semver
Current Version	5.5.0
Type	dependency

This version is covered by your current version range and after updating it in your project the build failed.

semver is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

Commits

The new version differs by 5 commits.

• 89bfa00 5.5.1
• acb44dd Update tap version
• 448b0b3 Update tap version
• 6069fe7 Merge pull request #247 from steveklabnik/patch-1
• 43ff1c7 Fix grammar for ranges

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

• engines was only updated if it defined a single version, not a range.
• .nvmrc was updated to Node.js 10
• .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of lodash is breaking the build 🚨

The dependency lodash was updated from 4.17.10 to 4.17.11.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lodash is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

---

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

An in-range update of probot is breaking the build 🚨

Version 6.2.0 of probot was just published.

Branch	Build failing 🚨
Dependency	probot
Current Version	6.1.0
Type	dependency

This version is covered by your current version range and after updating it in your project the build failed.

probot is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

• ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

---

Commits

The new version differs by 27 commits.

• 6139330 chore: Commit version number, remove snapshot tests (#535)
• 6ba287f docs: Add docs on unauthenticated events and a log warning (#536)
• f525df9 fix: Allow listening to installation.deleted event and other events that don't include an installation id (#475)
• 1748c63 Fix deprecatation warning for octokit authentication
• 97ca3a5 fix(package): update @octokit/rest to version ^15.6.0 (#533)
• d99f3bd chore: Test Node 9 and 10 in CI (#532)
• 38da738 Audit of readme based on maintainer audit feedback (#526)
• c0140b5 add ignore spammy/abusive user option for stats endpoint (#513)
• 4524ada docs: suggested changes from audit #522 (#523)
• 7250d1d docs: Issue templates (#525)
• 1bace4c docs: Remove the docs/deploy.md step... (#520)
• 70dd807 docs: Remove obsolete step for deploying to Now (#517)
• 42e23d4 Fix typo (#515)
• 544e662 doc: Added details about using the wildcard event (#504)
• cfe3cdd fix: throw informative error if payload is missing repository (#508)

There are 27 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

move code From Glitch to this repository

Code is at https://glitch.com/edit/#!/github-release-notifier-bot

part of #1

pnpm/pnpm release notification is failing

Feb 04 12:48:56 release-notifier heroku/router:  at=info method=POST path="/" host=release-notifier.herokuapp.com request_id=e5e0db52-c5dd-4a84-96a7-47f46a88cfca fwd="192.30.252.45" dyno=web.1 connect=1ms service=3ms status=200 bytes=231 protocol=https 
Feb 04 12:48:56 release-notifier app/web.1:  20:48:56.049Z  INFO probot: Webhook received 
Feb 04 12:48:56 release-notifier app/web.1:    event: { 
Feb 04 12:48:56 release-notifier app/web.1:      "id": "d1197b00-09ec-11e8-8f33-3693d81f747b", 
Feb 04 12:48:56 release-notifier app/web.1:      "event": "release.published", 
Feb 04 12:48:56 release-notifier app/web.1:      "repository": "pnpm/pnpm", 
Feb 04 12:48:56 release-notifier app/web.1:      "installation": 84166 
Feb 04 12:48:56 release-notifier app/web.1:    } 
Feb 04 12:48:56 release-notifier app/web.1:  20:48:56.050Z  INFO probot: POST / 200 - 1.80 ms (id=e5e0db52-c5dd-4a84-96a7-47f46a88cfca) 
Feb 04 12:48:56 release-notifier app/web.1:  20:48:56.067Z  INFO probot: v1.32.0 published! (id=d1197b00-09ec-11e8-8f33-3693d81f747b) 
Feb 04 12:48:56 release-notifier app/web.1:  20:48:56.190Z  INFO probot: previous release was v1.31.6 (2018-02-03T13:57:58Z) (id=d1197b00-09ec-11e8-8f33-3693d81f747b) 
Feb 04 12:48:57 release-notifier app/web.1:  20:48:57.155Z  INFO probot: commits between versions: 6 (id=d1197b00-09ec-11e8-8f33-3693d81f747b) 
Feb 04 12:48:58 release-notifier app/web.1:  20:48:58.145Z ERROR probot: 
Feb 04 12:48:58 release-notifier app/web.1:    Promise { 
Feb 04 12:48:58 release-notifier app/web.1:      <rejected> TypeError: Cannot read property 'number' of undefined 
Feb 04 12:48:58 release-notifier app/web.1:        at chain.map.compact.uniqBy.forEach (/app/index.js:66:46) 
Feb 04 12:48:58 release-notifier app/web.1:        at <anonymous> 
Feb 04 12:48:58 release-notifier app/web.1:        at process._tickDomainCallback (internal/process/next_tick.js:228:7) } 
Feb 04 12:48:58 release-notifier app/web.1:    -- 
Feb 04 12:48:58 release-notifier app/web.1:    TypeError: Cannot read property 'number' of undefined 
Feb 04 12:48:58 release-notifier app/web.1:        at chain.map.compact.uniqBy.forEach (/app/index.js:66:46) 
Feb 04 12:48:58 release-notifier app/web.1:        at <anonymous> 
Feb 04 12:48:58 release-notifier app/web.1:        at process._tickDomainCallback (internal/process/next_tick.js:228:7) 
Feb 04 13:06:16 release-notifier heroku/web.1:  Cycling 
Feb 04 13:06:16 release-notifier heroku/web.1:  State changed from up to starting 
Feb 04 13:06:16 release-notifier heroku/web.1:  Stopping all processes with SIGTERM 

Bug: commenting on PRs from the previous release

Example: electron/i18n#280 (comment)

I think the problem here may be that we're including commits from the previous release when searching:

release-notifier/index.js

Lines 48 to 53 in d817aed

	const {data: commits} = await context.github.repos.getCommits({
	owner,
	repo,
	sha: currentRelease.tag_name,
	since: previousRelease.created_at
	})

@gr2m does that sound right? Maybe should be searching for previousRelease.published_at instead of previousRelease.created_at?

The GitHub API search endpoint could be called only once

Hello!

I'm working on a similar feature for semantic-release. It would also add to the issue comments things that are only available in the context of semantic-release such as the links to the different release locations (e.g. GitHub release, Atom package, npm package + dist-tag info etc..).

I was looking at the code of this app to get started and while experimenting with the GitHub API I figured the search endpoint can be called once for multiple commits.

It seems that currently it's called for each commit in the release:

release-notifier/index.js

Line 60 in 9ae8ead

const {data: {items: [pullRequest]}} = await context.github.search.issues({q: commit.sha})

A list of commit sha can be passed separated by +. In addition passing the criteria repo:<owner>/<repo> would limit the search to the current repo (might help on GitHub side by limiting the scope) and type:pr allows to guarantee only PRs are returned (I found some cases where a random issue was returned in addition of the expected PR).

Doing so would limit the number of calls to the GitHub API, especially for releases that include a lot of commits.

You can see an example here.

On a side note, I created the module issue-parser that parses PRs, issues and commit body to find issues closed via keywords. It's used here and allow to also add a comment to issues closed from the PRs and commit via keywords. In case you are interested.

use a new avatar

Current avatar is a copy of probot, hue-shifted to green for a bit of distinction. 🙈

An in-range update of semantic-release is breaking the build 🚨

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 15.1.2 of semantic-release was just published.

Branch	Build failing 🚨
Dependency	semantic-release
Current Version	15.1.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

semantic-release is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

---

Release Notes

v15.1.2

15.1.2 (2018-03-16)

Bug Fixes

• prevent git CLI to prompt user/password on CI (7c48afa)

Commits

The new version differs by 1 commits.

• 7c48afa fix: prevent git CLI to prompt user/password on CI

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

next steps

🎉 we have a proof of concept 🎈

I think next steps are

• #2 move code From Glitch to this repository
• setup continuous deployment to now Heroku
• add some tests: #22
• add semantic-release (#5)
• add Greenkeeper
• find issues by parsing PR bodies and commit messages: #23
• add release-notifier on itself :)

... ?

Preleases

We currently ignore them, but could generate a special kind of notification for them.

Also, what happens when an existing prerelease is toggle to a "released" state on GitHub? Does this trigger a release.published webhook?

comment on issues too

Comments are currently created on Pull Requests that land in a release, but we should also be able to track down the source issues that are resolved by a release too.

cc @rsarky

failed for electron-typescript-definitions release

2018-02-12T19:34:40.761660+00:00 app[web.1]: 19:34:40.761Z  INFO probot: Webhook received
2018-02-12T19:34:40.761677+00:00 app[web.1]:   event: {
2018-02-12T19:34:40.761681+00:00 app[web.1]:     "id": "c4d67fb0-102b-11e8-902b-2ade65be984c",
2018-02-12T19:34:40.761685+00:00 app[web.1]:     "repository": "electron/electron-typescript-definitions",
2018-02-12T19:34:40.761683+00:00 app[web.1]:     "event": "release.published",
2018-02-12T19:34:40.761687+00:00 app[web.1]:     "installation": 83845
2018-02-12T19:34:40.762075+00:00 app[web.1]: 19:34:40.761Z  INFO probot: POST / 200 - 1.36 ms (id=7518b075-5ad0-442c-8f3d-2b93f0e81ac0)
2018-02-12T19:34:40.777867+00:00 app[web.1]: 19:34:40.777Z  INFO probot: v1.3.0 published! (id=c4d67fb0-102b-11e8-902b-2ade65be984c)
2018-02-12T19:34:40.761688+00:00 app[web.1]:   }
2018-02-12T19:34:40.990207+00:00 app[web.1]: 19:34:40.989Z DEBUG probot: GitHub request: GET /repos/:owner/:repo/releases - 200 OK (id=c4d67fb0-102b-11e8-902b-2ade65be984c, installation=83845)
2018-02-12T19:34:40.990216+00:00 app[web.1]:     "owner": "electron",
2018-02-12T19:34:40.762991+00:00 heroku[router]: at=info method=POST path="/" host=release-notifier.herokuapp.com request_id=7518b075-5ad0-442c-8f3d-2b93f0e81ac0 fwd="192.30.252.37" dyno=web.1 connect=1ms service=6ms status=200 bytes=231 protocol=https
2018-02-12T19:34:40.990218+00:00 app[web.1]:     "repo": "electron-typescript-definitions",
2018-02-12T19:34:40.990221+00:00 app[web.1]:   }
2018-02-12T19:34:40.990212+00:00 app[web.1]:   params: {
2018-02-12T19:34:40.990219+00:00 app[web.1]:     "per_page": 50
2018-02-12T19:34:40.990549+00:00 app[web.1]: 19:34:40.990Z  INFO probot: no previous releases found with a lower semantic version (aborting) (id=c4d67fb0-102b-11e8-902b-2ade65be984c)

An in-range update of nodemon is breaking the build 🚨

Version 1.17.5 of nodemon was just published.

Branch	Build failing 🚨
Dependency	nodemon
Current Version	1.17.4
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

nodemon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

• ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

---

Release Notes

v1.17.5

1.17.5 (2018-05-23)

Bug Fixes

• in watch, use fully filtered ignore rules (b3fc3a9), closes #1348

Commits

The new version differs by 2 commits.

• b3fc3a9 fix: in watch, use fully filtered ignore rules
• ff79835 chore: update stalebot

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

---

Your Greenkeeper Bot 🌴

Add labels to PRs

cc @alexeykuzmin @MarshallOfSound @codebytere

Release comment are missing on PRs

Yesterday I install the release-notifier app on the OctoLinker repo. Today I've created a new release and I expected to see comments on all past PRs between this and the previous release.

For some reason I only got one comment on the version bump PR itself OctoLinker/OctoLinker#439. All the referenced PRs doesn't have a comment.

I browsed through the release-notifier source, but I couldn't find anything. Let me know how I can help to track it down.