rekby / gpt Goto Github PK

gpt.ReadTable expects for the filehandle provided to be positioned
at the partition table offset (which is likely 512 bytes).

While it is useful in allowing the user to provide a partition table
directly without the leading LBA, it means that the simple use case
below does not work:

fp, err := os.Open(fname)
gptTable, err := gpt.ReadTable(fp, SECTOR_SIZE)

ReadTable does have a comment stating:

// Read GPT partition
// Have to set to first byte of GPT Header (usually start of second sector on disk)

I lost some time figuring out why my code was failing after dropping the an 'mbr.Read' that seemed unnecessary. In reality, the mbr.Read was providing the side effect of moving the position in 1 sector and making it work.

I'd provide a pull request to simply do a 'Seek(0, 0)' but I do see the value in reading directly from the file directly as provided. My second option would be to add a 'Read' function that took a filehandle, did a Seek(0, 0) and then called ReadTable.

What do you think?