rekalogika / mapper Goto Github PK

Problem

Trying to map one object to another object, $this->mapper->map($dto, $entity); fails due to invalid cache key name:

Cache key "App\DTO\BookDto:App\Entity\Book" contains reserved characters "{}()/\@:".

Cause

Invalid cache key name is created here:

Reproduction

• Symfony setup (6.4+) with Redis cache adapter
  • It should not matter which type of cache adapter you'd use to reproduce, as all adapters extend from the Symfony AbstractAdapter, which use the AbstractAdapterTrait to validate the key name.

Version

• rekalogika/mapper: v0.8.0
• symfony/cache: v7.0.3

Problem

I've noticed that nullable properties get cast to empty string ("") instead of being kept as null value when not using constructor property promotion in the target class.

Reproduction

src/Dto/BookDto.php

namespace App\Dto;

class BookDto
{
    public function __construct(
        public string|null $title = null,
    ) {
    }
}

src/Entity/Book.php

namespace App\Entity;

class Book
{
    private string|null $title = null;

    public function __construct(
        private int $id,
    ) {
    }

    public function getId(): ?int
    {
        return $this->id;
    }

    public function getTitle(): ?string
    {
        return $this->title;
    }
}

Run mapper

$book = new \App\Entity\Book(1);
$this->mapper->map(new \App\Dto\BookDto(null), $book);

Result

App\Entity\Book {#2485 ▼
  -id: 1
  -notes: ""
}

Question

Does this mapper allow to map object to another object when the property names differ, without creating a custom transfomer?

Example (from docs)

src/Entity/Book.php

namespace App\Entity;

class Book
{
    public function __construct(
        private int $id,
        private string $title,
    ) {
    }

    public function getId(): ?int
    {
        return $this->id;
    }

    public function getTitle(): ?string
    {
        return $this->title;
    }
}

src/Dto/BookDto.php

namespace App\Dto;

class BookDto
{
    public string $id;
    public string $name; // changed this to $name instead of $title
}

How would I map the Book::title to BookDto::name?

I was previously looking at thephpleague/object-mapper, which doesn't really suit fit my use case as it does not allow object-to-object mapping directly but I saw it uses attributes like #[MapFrom] which allows to allow for custom mapping between property names. I'm not sure if there's already something similar in this library, but maybe something similar would be nice to have (if not already).