rehooks / window-scroll-position Goto Github PK

The PR #5 introduced a handleScroll.cancel() but there is no property cancel on the handler function. So, on component unmount, an error is thrown and thus the removeEventListener is never called.

Hey, is this not production ready? I tried to install on npm, and no dice.

npm ERR! code E404
npm ERR! 404 Not Found: @rehooks/window-scroll-position@latest

I was reading the hook source code and I was wondering if it really needs to specify {passive: true}. The scroll event should be passive by default since it cannot be cancelled. Check the last paragraph:

You don't need to worry about the value of passive for the basic scroll event. Since it can't be canceled, event listeners can't block page rendering anyway.

Building for production environment:

ERROR in ....js from UglifyJs
Unexpected token: punc ({) [./node_modules/@rehooks/window-scroll-position/index.js:2,0]

Great util guys! Im super excited about hooks!

I was working on something with a scroll listener and I came across MDN example.
MDN scroll event throttling

hook Implementation:
https://codepen.io/bmgaynor/pen/aXWzEa

Let me know what you guys think.

Tried to use this with next.js, which has SSR out-of-the-box.

I am getting the window is not defined error. Consider running code that uses window from useEffect hooks, so they only run on the client.