regoth-project / automate-vcpkg Goto Github PK

1. message("Bootstrapping vcpkg in ${VCPKG_ROOT}") should read message(STATUS "Bootstrapping vcpkg in ${VCPKG_ROOT}")
2. execute_process(COMMAND ${VCPKG_BOOTSTRAP} WORKING_DIRECTORY ${VCPKG_ROOT}) could include -disableMetrics , i.e. execute_process(COMMAND ${VCPKG_BOOTSTRAP} -disableMetrics WORKING_DIRECTORY ${VCPKG_ROOT}). Perhaps make it a configuration parameter?
3. (nit) You should set your editor to trim trailing whitespace at end of line.

Thanks! Great product.

Hey! I like your helpful script, saved me from some headaches.. had to do a small modification though. If you are still maintaining this here is what I did:

From here: line 97
To here: line 100

From my testing, those can be moved under else statement at line 92 to fix first-time CMake generation complaining about missing file for the include.

else()
    set(VCPKG_ROOT $ENV{VCPKG_ROOT})

    # We know this wasn't set before so we need point the toolchain file to the newly found VCPKG_ROOT
    set(CMAKE_TOOLCHAIN_FILE ${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake CACHE STRING "")

    # Just setting vcpkg.cmake as toolchain file does not seem to actually pull in the code
    include(${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake)
endif()

Two possible problems. First, in vcpkg_install_packages you have
# Need the given list to be space-separated #string (REPLACE ";" " " PACKAGES_LIST_STR "${ARGN}")
but then
execute_process( COMMAND ${VCPKG_EXEC} install ${ARGN} WORKING_DIRECTORY ${VCPKG_ROOT} )
If the first line matters, then shouldn't that ${ARGN} be ${PACKAGES_LIST_STR}?

Second, the argument list could become too long for the command processor on 'some systems' (you know which I mean) . It should best be processed in a loop.

Trying to set VCPKG_ROOT either as ENV or normal variable in parent CMakeLists would result it in being ignored and fallback being used instead.

In my case modifying the check and putting it inside vcpkg_bootstrap works. Not sure if this would work well with environment variable from terminal or such.

if(NOT VCPKG_ROOT)
	set(VCPKG_ROOT ${VCPKG_FALLBACK_ROOT})
endif()