redpangilinan / iotawise Goto Github PK

Hey! I noticed there is a timezone issue when creating Activity Logs. When creating a log, it is automatically adding the user's Timezone (I am in EST, GMT-5)

This creates an issue when the user selects a date range. When selected, the range does not include a timezone so the logs on the last day of the range are not included in subsequent results. When manually updating the "to" date in the URL to include a time later than the timezone offset, the user will see the correct results.

There is a function formatDate

function formatDate(e) {
    let t = new Date(e);
    return Intl.DateTimeFormat("en-US", {
        month: "short",
        day: "numeric",
        year: "numeric"
    }).format(t)
}

that was given amongst many correct dates an e = "16/01/2024" which caused to throw an error and whole dashboard fails to load (it shows only: "Application error: a client-side exception has occurred (see the browser console for more information).").

After inspecting a call stack it seems the problem lays in a function LogsDeleteButton that converts this date (in a correct format "Tue Jan 16 2024 ...") using t.date.toLocaleDateString() which is later passed to formatDate which causes an error.

I failed to compile it locally (I would be glad for an updated Running Locally section of README), but I assume that changing
Delete logs from {formatDate(logs.date.toLocaleDateString())}?
to Delete logs from {formatDate(logs.date)}?
in components/activity/logs/logs-delete-button.tsx should fix the issue, but I'm unable to confirm.

Suggestion: Add a "Quick Log" button next to an activity dropdown on a dashboard. It should immediatelly create a log with single count on today's date. Users will mostly log a simple entry, choosing an "Add Log" from a dropdown, then filling a form, and confirming it just makes a simple task very tedious.

PS: Great simple app, just what I was looking for, thank you!
I would gladly contribute, I'll just need to learn some typescript first.

These are minor bugs, but in my opinion, they are noise that devalues ​​this cool project.

UPD: Remove the description as required to create an activity