Coder Social home page Coder Social logo

redis-rb's Introduction

This README is just a fast quick start document. You can find more detailed documentation at redis.io.

What is Redis?

Redis is often referred to as a data structures server. What this means is that Redis provides access to mutable data structures via a set of commands, which are sent using a server-client model with TCP sockets and a simple protocol. So different processes can query and modify the same data structures in a shared way.

Data structures implemented into Redis have a few special properties:

  • Redis cares to store them on disk, even if they are always served and modified into the server memory. This means that Redis is fast, but that it is also non-volatile.
  • The implementation of data structures emphasizes memory efficiency, so data structures inside Redis will likely use less memory compared to the same data structure modelled using a high-level programming language.
  • Redis offers a number of features that are natural to find in a database, like replication, tunable levels of durability, clustering, and high availability.

Another good example is to think of Redis as a more complex version of memcached, where the operations are not just SETs and GETs, but operations that work with complex data types like Lists, Sets, ordered data structures, and so forth.

If you want to know more, this is a list of selected starting points:

Building Redis

Redis can be compiled and used on Linux, OSX, OpenBSD, NetBSD, FreeBSD. We support big endian and little endian architectures, and both 32 bit and 64 bit systems.

It may compile on Solaris derived systems (for instance SmartOS) but our support for this platform is best effort and Redis is not guaranteed to work as well as in Linux, OSX, and *BSD.

It is as simple as:

% make

To build with TLS support, you'll need OpenSSL development libraries (e.g. libssl-dev on Debian/Ubuntu) and run:

% make BUILD_TLS=yes

To build with systemd support, you'll need systemd development libraries (such as libsystemd-dev on Debian/Ubuntu or systemd-devel on CentOS) and run:

% make USE_SYSTEMD=yes

To append a suffix to Redis program names, use:

% make PROG_SUFFIX="-alt"

You can build a 32 bit Redis binary using:

% make 32bit

After building Redis, it is a good idea to test it using:

% make test

If TLS is built, running the tests with TLS enabled (you will need tcl-tls installed):

% ./utils/gen-test-certs.sh
% ./runtest --tls

Fixing build problems with dependencies or cached build options

Redis has some dependencies which are included in the deps directory. make does not automatically rebuild dependencies even if something in the source code of dependencies changes.

When you update the source code with git pull or when code inside the dependencies tree is modified in any other way, make sure to use the following command in order to really clean everything and rebuild from scratch:

% make distclean

This will clean: jemalloc, lua, hiredis, linenoise and other dependencies.

Also if you force certain build options like 32bit target, no C compiler optimizations (for debugging purposes), and other similar build time options, those options are cached indefinitely until you issue a make distclean command.

Fixing problems building 32 bit binaries

If after building Redis with a 32 bit target you need to rebuild it with a 64 bit target, or the other way around, you need to perform a make distclean in the root directory of the Redis distribution.

In case of build errors when trying to build a 32 bit binary of Redis, try the following steps:

  • Install the package libc6-dev-i386 (also try g++-multilib).
  • Try using the following command line instead of make 32bit: make CFLAGS="-m32 -march=native" LDFLAGS="-m32"

Allocator

Selecting a non-default memory allocator when building Redis is done by setting the MALLOC environment variable. Redis is compiled and linked against libc malloc by default, with the exception of jemalloc being the default on Linux systems. This default was picked because jemalloc has proven to have fewer fragmentation problems than libc malloc.

To force compiling against libc malloc, use:

% make MALLOC=libc

To compile against jemalloc on Mac OS X systems, use:

% make MALLOC=jemalloc

Monotonic clock

By default, Redis will build using the POSIX clock_gettime function as the monotonic clock source. On most modern systems, the internal processor clock can be used to improve performance. Cautions can be found here: http://oliveryang.net/2015/09/pitfalls-of-TSC-usage/

To build with support for the processor's internal instruction clock, use:

% make CFLAGS="-DUSE_PROCESSOR_CLOCK"

Verbose build

Redis will build with a user-friendly colorized output by default. If you want to see a more verbose output, use the following:

% make V=1

Running Redis

To run Redis with the default configuration, just type:

% cd src
% ./redis-server

If you want to provide your redis.conf, you have to run it using an additional parameter (the path of the configuration file):

% cd src
% ./redis-server /path/to/redis.conf

It is possible to alter the Redis configuration by passing parameters directly as options using the command line. Examples:

% ./redis-server --port 9999 --replicaof 127.0.0.1 6379
% ./redis-server /etc/redis/6379.conf --loglevel debug

All the options in redis.conf are also supported as options using the command line, with exactly the same name.

Running Redis with TLS:

Please consult the TLS.md file for more information on how to use Redis with TLS.

Playing with Redis

You can use redis-cli to play with Redis. Start a redis-server instance, then in another terminal try the following:

% cd src
% ./redis-cli
redis> ping
PONG
redis> set foo bar
OK
redis> get foo
"bar"
redis> incr mycounter
(integer) 1
redis> incr mycounter
(integer) 2
redis>

You can find the list of all the available commands at https://redis.io/commands.

Installing Redis

In order to install Redis binaries into /usr/local/bin, just use:

% make install

You can use make PREFIX=/some/other/directory install if you wish to use a different destination.

make install will just install binaries in your system, but will not configure init scripts and configuration files in the appropriate place. This is not needed if you just want to play a bit with Redis, but if you are installing it the proper way for a production system, we have a script that does this for Ubuntu and Debian systems:

% cd utils
% ./install_server.sh

Note: install_server.sh will not work on Mac OSX; it is built for Linux only.

The script will ask you a few questions and will setup everything you need to run Redis properly as a background daemon that will start again on system reboots.

You'll be able to stop and start Redis using the script named /etc/init.d/redis_<portnumber>, for instance /etc/init.d/redis_6379.

Code contributions

By contributing code to the Redis project in any form, including sending a pull request via GitHub, a code fragment or patch via private email or public discussion groups, you agree to release your code under the terms of the Redis Software Grant and Contributor License Agreement. Redis software contains contributions to the original Redis core project, which are owned by their contributors and licensed under the 3BSD license. Any copy of that license in this repository applies only to those contributions. Redis releases all Redis project versions from 7.4.x and thereafter under the RSALv2/SSPL dual-license as described in the LICENSE.txt file included in the Redis source distribution.

Please see the CONTRIBUTING.md file in this source distribution for more information. For security bugs and vulnerabilities, please see SECURITY.md.

Redis Trademarks

The purpose of a trademark is to identify the goods and services of a person or company without causing confusion. As the registered owner of its name and logo, Redis accepts certain limited uses of its trademarks but it has requirements that must be followed as described in its Trademark Guidelines available at: https://redis.com/legal/trademark-guidelines/.

Redis internals

If you are reading this README you are likely in front of a Github page or you just untarred the Redis distribution tar ball. In both the cases you are basically one step away from the source code, so here we explain the Redis source code layout, what is in each file as a general idea, the most important functions and structures inside the Redis server and so forth. We keep all the discussion at a high level without digging into the details since this document would be huge otherwise and our code base changes continuously, but a general idea should be a good starting point to understand more. Moreover most of the code is heavily commented and easy to follow.

Source code layout

The Redis root directory just contains this README, the Makefile which calls the real Makefile inside the src directory and an example configuration for Redis and Sentinel. You can find a few shell scripts that are used in order to execute the Redis, Redis Cluster and Redis Sentinel unit tests, which are implemented inside the tests directory.

Inside the root are the following important directories:

  • src: contains the Redis implementation, written in C.
  • tests: contains the unit tests, implemented in Tcl.
  • deps: contains libraries Redis uses. Everything needed to compile Redis is inside this directory; your system just needs to provide libc, a POSIX compatible interface and a C compiler. Notably deps contains a copy of jemalloc, which is the default allocator of Redis under Linux. Note that under deps there are also things which started with the Redis project, but for which the main repository is not redis/redis.

There are a few more directories but they are not very important for our goals here. We'll focus mostly on src, where the Redis implementation is contained, exploring what there is inside each file. The order in which files are exposed is the logical one to follow in order to disclose different layers of complexity incrementally.

Note: lately Redis was refactored quite a bit. Function names and file names have been changed, so you may find that this documentation reflects the unstable branch more closely. For instance, in Redis 3.0 the server.c and server.h files were named redis.c and redis.h. However the overall structure is the same. Keep in mind that all the new developments and pull requests should be performed against the unstable branch.

server.h

The simplest way to understand how a program works is to understand the data structures it uses. So we'll start from the main header file of Redis, which is server.h.

All the server configuration and in general all the shared state is defined in a global structure called server, of type struct redisServer. A few important fields in this structure are:

  • server.db is an array of Redis databases, where data is stored.
  • server.commands is the command table.
  • server.clients is a linked list of clients connected to the server.
  • server.master is a special client, the master, if the instance is a replica.

There are tons of other fields. Most fields are commented directly inside the structure definition.

Another important Redis data structure is the one defining a client. In the past it was called redisClient, now just client. The structure has many fields, here we'll just show the main ones:

struct client {
    int fd;
    sds querybuf;
    int argc;
    robj **argv;
    redisDb *db;
    int flags;
    list *reply;
    // ... many other fields ...
    char buf[PROTO_REPLY_CHUNK_BYTES];
}

The client structure defines a connected client:

  • The fd field is the client socket file descriptor.
  • argc and argv are populated with the command the client is executing, so that functions implementing a given Redis command can read the arguments.
  • querybuf accumulates the requests from the client, which are parsed by the Redis server according to the Redis protocol and executed by calling the implementations of the commands the client is executing.
  • reply and buf are dynamic and static buffers that accumulate the replies the server sends to the client. These buffers are incrementally written to the socket as soon as the file descriptor is writable.

As you can see in the client structure above, arguments in a command are described as robj structures. The following is the full robj structure, which defines a Redis object:

struct redisObject {
    unsigned type:4;
    unsigned encoding:4;
    unsigned lru:LRU_BITS; /* LRU time (relative to global lru_clock) or
                            * LFU data (least significant 8 bits frequency
                            * and most significant 16 bits access time). */
    int refcount;
    void *ptr;
};

Basically this structure can represent all the basic Redis data types like strings, lists, sets, sorted sets and so forth. The interesting thing is that it has a type field, so that it is possible to know what type a given object has, and a refcount, so that the same object can be referenced in multiple places without allocating it multiple times. Finally the ptr field points to the actual representation of the object, which might vary even for the same type, depending on the encoding used.

Redis objects are used extensively in the Redis internals, however in order to avoid the overhead of indirect accesses, recently in many places we just use plain dynamic strings not wrapped inside a Redis object.

server.c

This is the entry point of the Redis server, where the main() function is defined. The following are the most important steps in order to startup the Redis server.

  • initServerConfig() sets up the default values of the server structure.
  • initServer() allocates the data structures needed to operate, setup the listening socket, and so forth.
  • aeMain() starts the event loop which listens for new connections.

There are two special functions called periodically by the event loop:

  1. serverCron() is called periodically (according to server.hz frequency), and performs tasks that must be performed from time to time, like checking for timed out clients.
  2. beforeSleep() is called every time the event loop fired, Redis served a few requests, and is returning back into the event loop.

Inside server.c you can find code that handles other vital things of the Redis server:

  • call() is used in order to call a given command in the context of a given client.
  • activeExpireCycle() handles eviction of keys with a time to live set via the EXPIRE command.
  • performEvictions() is called when a new write command should be performed but Redis is out of memory according to the maxmemory directive.
  • The global variable redisCommandTable defines all the Redis commands, specifying the name of the command, the function implementing the command, the number of arguments required, and other properties of each command.

commands.c

This file is auto generated by utils/generate-command-code.py, the content is based on the JSON files in the src/commands folder. These are meant to be the single source of truth about the Redis commands, and all the metadata about them. These JSON files are not meant to be used by anyone directly, instead that metadata can be obtained via the COMMAND command.

networking.c

This file defines all the I/O functions with clients, masters and replicas (which in Redis are just special clients):

  • createClient() allocates and initializes a new client.
  • The addReply*() family of functions are used by command implementations in order to append data to the client structure, that will be transmitted to the client as a reply for a given command executed.
  • writeToClient() transmits the data pending in the output buffers to the client and is called by the writable event handler sendReplyToClient().
  • readQueryFromClient() is the readable event handler and accumulates data read from the client into the query buffer.
  • processInputBuffer() is the entry point in order to parse the client query buffer according to the Redis protocol. Once commands are ready to be processed, it calls processCommand() which is defined inside server.c in order to actually execute the command.
  • freeClient() deallocates, disconnects and removes a client.

aof.c and rdb.c

As you can guess from the names, these files implement the RDB and AOF persistence for Redis. Redis uses a persistence model based on the fork() system call in order to create a process with the same (shared) memory content of the main Redis process. This secondary process dumps the content of the memory on disk. This is used by rdb.c to create the snapshots on disk and by aof.c in order to perform the AOF rewrite when the append only file gets too big.

The implementation inside aof.c has additional functions in order to implement an API that allows commands to append new commands into the AOF file as clients execute them.

The call() function defined inside server.c is responsible for calling the functions that in turn will write the commands into the AOF.

db.c

Certain Redis commands operate on specific data types; others are general. Examples of generic commands are DEL and EXPIRE. They operate on keys and not on their values specifically. All those generic commands are defined inside db.c.

Moreover db.c implements an API in order to perform certain operations on the Redis dataset without directly accessing the internal data structures.

The most important functions inside db.c which are used in many command implementations are the following:

  • lookupKeyRead() and lookupKeyWrite() are used in order to get a pointer to the value associated to a given key, or NULL if the key does not exist.
  • dbAdd() and its higher level counterpart setKey() create a new key in a Redis database.
  • dbDelete() removes a key and its associated value.
  • emptyData() removes an entire single database or all the databases defined.

The rest of the file implements the generic commands exposed to the client.

object.c

The robj structure defining Redis objects was already described. Inside object.c there are all the functions that operate with Redis objects at a basic level, like functions to allocate new objects, handle the reference counting and so forth. Notable functions inside this file:

  • incrRefCount() and decrRefCount() are used in order to increment or decrement an object reference count. When it drops to 0 the object is finally freed.
  • createObject() allocates a new object. There are also specialized functions to allocate string objects having a specific content, like createStringObjectFromLongLong() and similar functions.

This file also implements the OBJECT command.

replication.c

This is one of the most complex files inside Redis, it is recommended to approach it only after getting a bit familiar with the rest of the code base. In this file there is the implementation of both the master and replica role of Redis.

One of the most important functions inside this file is replicationFeedSlaves() that writes commands to the clients representing replica instances connected to our master, so that the replicas can get the writes performed by the clients: this way their data set will remain synchronized with the one in the master.

This file also implements both the SYNC and PSYNC commands that are used in order to perform the first synchronization between masters and replicas, or to continue the replication after a disconnection.

Script

The script unit is composed of 3 units:

  • script.c - integration of scripts with Redis (commands execution, set replication/resp, ...)
  • script_lua.c - responsible to execute Lua code, uses script.c to interact with Redis from within the Lua code.
  • function_lua.c - contains the Lua engine implementation, uses script_lua.c to execute the Lua code.
  • functions.c - contains Redis Functions implementation (FUNCTION command), uses functions_lua.c if the function it wants to invoke needs the Lua engine.
  • eval.c - contains the eval implementation using script_lua.c to invoke the Lua code.

Other C files

  • t_hash.c, t_list.c, t_set.c, t_string.c, t_zset.c and t_stream.c contains the implementation of the Redis data types. They implement both an API to access a given data type, and the client command implementations for these data types.
  • ae.c implements the Redis event loop, it's a self contained library which is simple to read and understand.
  • sds.c is the Redis string library, check https://github.com/antirez/sds for more information.
  • anet.c is a library to use POSIX networking in a simpler way compared to the raw interface exposed by the kernel.
  • dict.c is an implementation of a non-blocking hash table which rehashes incrementally.
  • cluster.c implements the Redis Cluster. Probably a good read only after being very familiar with the rest of the Redis code base. If you want to read cluster.c make sure to read the Redis Cluster specification.

Anatomy of a Redis command

All the Redis commands are defined in the following way:

void foobarCommand(client *c) {
    printf("%s",c->argv[1]->ptr); /* Do something with the argument. */
    addReply(c,shared.ok); /* Reply something to the client. */
}

The command function is referenced by a JSON file, together with its metadata, see commands.c described above for details. The command flags are documented in the comment above the struct redisCommand in server.h. For other details, please refer to the COMMAND command. https://redis.io/commands/command/

After the command operates in some way, it returns a reply to the client, usually using addReply() or a similar function defined inside networking.c.

There are tons of command implementations inside the Redis source code that can serve as examples of actual commands implementations (e.g. pingCommand). Writing a few toy commands can be a good exercise to get familiar with the code base.

There are also many other files not described here, but it is useless to cover everything. We just want to help you with the first steps. Eventually you'll find your way inside the Redis code base :-)

Enjoy!

redis-rb's People

Contributors

allomov avatar antirez avatar badboy avatar bitterb avatar bpo avatar byroot avatar darshanime avatar defunkt avatar dependabot[bot] avatar djanowski avatar esmarkowski avatar evanphx avatar fatkodima avatar igrigorik avatar ioquatix avatar jeremy avatar jodosha avatar matflores avatar mperham avatar not-a-robot[bot] avatar petergoldstein avatar pietern avatar qrush avatar quixoten avatar rsanheim avatar soveran avatar supercaracal avatar tarcieri avatar thesmartnik avatar yaauie avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

redis-rb's Issues

A SignalException occurred... SIGTERM

We're not sure why this is happening, but we saw significant app slowdowns after implementing Vanity, and saw this in the logs:

A SignalException occurred in friends#new:

SIGTERM
/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:246:in `write'


Backtrace:

/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:246:in write' /opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:246:inprocess_command'
/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:240:in raw_call_command' /opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:257:incall'
/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:257:in maybe_lock' /opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:240:inraw_call_command'
/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:195:in call_command' /opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/vendor/redis-rb/lib/redis.rb:183:inmethod_missing'
/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/lib/vanity/experiment/base.rb:167:in active?' /opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/lib/vanity/experiment/ab_test.rb:189:inchoose'
/opt/local/ruby-enterprise-1.8.6-20090610/lib/ruby/gems/1.8/gems/vanity-1.2.0/lib/vanity/rails/helpers.rb:91:in `ab_test'

Difference between Redis#keys and DistRedis#keys

I was wondering why DistRedis#keys doesn't follow the same api as Redis#keys:

# A DistRedis with two hosts
dist_redis.keys('*') # => [['k1'],['k2']]
redis.keys('*') # => ['k1','k2']

I'd prefer that the existing behavior ofDistRedis#keys be moved to another method name (DistRedis#node_keys?) and DistRedis#keys return a flattened array of keys. Seems to me that I should be able to swap out an instance of Redis with DistRedis in an application with no changes. I'd happily create a patch...

Protocol error, got ' ' as initial reply byte

Hello,
I got this error after some time working on production. I use redis-1.2.6. Here is a trace:

 Protocol error, got ' ' as initial reply byte
   /usr/local/lib/ruby/gems/1.8/gems/ezmobius-redis-0.1/lib/redis.rb:296:in `read_reply'
   /usr/local/lib/ruby/gems/1.8/gems/ezmobius-redis-0.1/lib/redis.rb:200:in `raw_call_command'
   /usr/local/lib/ruby/gems/1.8/gems/ezmobius-redis-0.1/lib/redis.rb:198:in `map'
   /usr/local/lib/ruby/gems/1.8/gems/ezmobius-redis-0.1/lib/redis.rb:198:in `raw_call_command'
   /usr/local/lib/ruby/gems/1.8/gems/ezmobius-redis-0.1/lib/redis.rb:163:in `call_command'
   /usr/local/lib/ruby/gems/1.8/gems/redis-store-0.3.7/lib/redis/marshaled_redis.rb:13:in `get'
   /usr/local/lib/ruby/gems/1.8/gems/redis-store-0.3.7/lib/cache/rails/redis_store.rb:27:in `read'

I assume this is a redis bug?

pubsub issue - Protocol error, got '1' as initial reply byte

This error is to do with pubsub. Basically, I think that the wrong TCPSockets are getting subscription messages. The '1', referred to below, was published to redis, but by a different instance of the Redis class (and therefore a different connection and TCPSocket)

Protocol error, got '1' as initial reply byte
/Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:554:in format_reply' /Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:486:inread_reply'
/Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:456:in block in process_command' /Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:454:inmap'
/Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:454:in process_command' /Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:443:inblock in raw_call_command'
/Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:464:in call' /Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:464:inmaybe_lock'
/Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:440:in raw_call_command' /Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:344:incall_command'
/Users/Alex/.bundle/ruby/1.9.1/gems/redis-1.0.6/lib/redis/client.rb:178:in `get'

To replicate:

  • Publish to a key
  • Do any other redis operation, like 'get' a value

Using hmset loses the last value

To reproduce, in script/console:

r = Redis.new
=> #<Redis::Client:0x105b58938 @sock=nil, @thread_safe=nil, @timeout=5, @host="127.0.0.1", @db=0, @password=nil, @binary_keys=nil, @PubSub=false, @logger=nil, @PORT=6379>
r.hmset(123, "foo", "bar", "foo2", "bar2")
=> "OK"

Then in redis-cli:
redis> hgetall 123

  1. foo
  2. bar
  3. foo2

The value of key "foo2" is empty. I tested mset and it seems to be okay, so since it looks like both commands share code I'm guessing there might be a difference in the protocol, but I haven't really studied that yet.

I also noticed some odd behavior with hget:

r.hgetall(123)
RuntimeError: -ERR wrong number of arguments for 'set' command
r.hget(123, "foo2")
=> ["foo", "bar", "foo2", ""]
r.hget(123)
=> ""

I just came across this and haven't explored further yet, though.

Getting results of pipelined commands

I was using the pipeline command to do "atomic gets" on a few related items and I found that it was impossible with redis-rb today.

Naive attempt:
@r.set("k1","v1")
@r.set("k2","v2")
@r.pipelined do |pipeline|
v1 = pipeline.get("k1")
v2 = pipeline.get("k2")
end
assert_equal "v1", v1
assert_equal "v2", v2

Running this test fails beacause v1 actually equals nil since the get result hasn't been collected yet.

One way to solve this with minimal work is to return an array with the result of all pipelined operations from the pipelined block. I looked at the code and it turns out this was very easy to implement. All of the results are being collected we just needed to return them at the end of the pipeline block. Now we can write:

v1, v2 = @r.pipelined do |pipeline|
  pipeline.get("k1")
  pipeline.get("k2")
end
assert_equal "v1", v1
assert_equal "v2", v2

Another way to handle this would be with futures but that would be a bit more magical and would lead people to think they could do things like:

@r.pipelined do |pipeline|
  v1_future = pipeline.get("k1")
  pipeline.set("k2", v1_future.get)
end

This is not valid since the set command is sent to the server with the parameters already fixed. For now I think returning the values is a neat way to handle the issue. I am sending you a pull request with the change and a test case.

Regression: redis.set returns "OK" rather than true

Ezra-

My redis-objects gem is based on redis-rb, and as of 1.0.3/1.0.4 timeframe, this command:

redis.set(key, value)

Now returns "OK" rather than true. I think this is a regression, as all of the rest of the redis-rb commands that would get "OK" back from redis-server are properly being mapped to true still.

Thanks,
Nate

Gem?

I can't seem to find a gem on Rubyforge or Gemcutter that's not empty. Can you push one when you have time?

Thanks!

Can I have a disconnect plz

Just doesn't feel right without one. Either Redis.close or Redis.disconnect will do.

Thanks for the great gem.

Failing tests in SREM command (minor issue)

$ rake
Loaded suite /home/anibal/.gem/ruby/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader
Started
..P.P................................................P...P..P.P..P..P...........................F.F.........P..............
Finished in 10.152636 seconds.

  1. Failure:
    test_Does_not_send_extra_commands_on_errors(RedisTest::TestInternals) [./test/redis_test.rb:66]:
    <[]> exception expected but was
    Class:
    Message: <"-ERR wrong number of arguments for 'srem' command">
    ---Backtrace---
    ./test/../lib/redis/client.rb:545:in format_error_reply' ./test/../lib/redis/client.rb:535:informat_reply'
    ./test/../lib/redis/client.rb:474:in read_reply' ./test/../lib/redis/client.rb:444:inprocess_command'
    ./test/../lib/redis/client.rb:442:in map' ./test/../lib/redis/client.rb:442:inprocess_command'
    ./test/../lib/redis/client.rb:431:in raw_call_command' ./test/../lib/redis/client.rb:452:incall'
    ./test/../lib/redis/client.rb:452:in maybe_lock' ./test/../lib/redis/client.rb:428:inraw_call_command'
    ./test/../lib/redis/client.rb:332:in call_command' ./test/../lib/redis/client.rb:381:inmethod_missing'
    ./test/redis_test.rb:67:in `test_Does_not_send_extra_commands_on_errors'

./test/redis_test.rb:66:in `test_Does_not_send_extra_commands_on_errors'

  1. Failure:
    test_Recovers_from_failed_commands(RedisTest::TestInternals) [./test/redis_test.rb:54]:
    <[]> exception expected but was
    Class:
    Message: <"-ERR wrong number of arguments for 'srem' command">
    ---Backtrace---
    ./test/../lib/redis/client.rb:545:in format_error_reply' ./test/../lib/redis/client.rb:535:informat_reply'
    ./test/../lib/redis/client.rb:474:in read_reply' ./test/../lib/redis/client.rb:444:inprocess_command'
    ./test/../lib/redis/client.rb:442:in map' ./test/../lib/redis/client.rb:442:inprocess_command'
    ./test/../lib/redis/client.rb:431:in raw_call_command' ./test/../lib/redis/client.rb:452:incall'
    ./test/../lib/redis/client.rb:452:in maybe_lock' ./test/../lib/redis/client.rb:428:inraw_call_command'
    ./test/../lib/redis/client.rb:332:in call_command' ./test/../lib/redis/client.rb:381:inmethod_missing'
    ./test/redis_test.rb:55:in `test_Recovers_from_failed_commands'

./test/redis_test.rb:54:in `test_Recovers_from_failed_commands'

114 tests, 584 assertions, 2 failures, 0 errors
rake aborted!
Command failed with status (1): [/usr/bin/ruby1.8 -I"lib" "/home/anibal/.ge...]

(See full trace by running task with --trace)

REDIS-RB INFO:

$ git branch

  • master
    $ git remote
    origin
    $ git log -1
    commit 9e43fde
    Author: Damian Janowski [email protected]
    Date: Thu Apr 8 09:45:45 2010 -0300

    Check for Ruby 1.9 as early as possible.

REDIS INFO:

$ git branch

  • master
    $ git remote -v
    origin git://github.com/antirez/redis.git
    $ git log -1
    commit dae121d9aa38626db9962ff02879b55eb7ca36bf
    Author: antirez [email protected]
    Date: Sat Apr 10 11:14:11 2010 +0200

    dict.c fixed to play well with enabling/disabling of the hash table

$ ./redis-server
[15568] 10 Apr 08:06:52 # Warning: no config file specified, using the default config. In order to specify a config file use 'redis-server /path/to/redis.conf'
[15568] 10 Apr 08:06:52 * Server started, Redis version 1.3.8
[15568] 10 Apr 08:06:52 # WARNING overcommit_memory is set to 0! Background save may fail under low condition memory. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
[15568] 10 Apr 08:06:52 * DB loaded from disk: 0 seconds
[15568] 10 Apr 08:06:52 * The server is now ready to accept connections on port 6379
[15568] 10 Apr 08:06:53 - DB 0: 3 keys (0 volatile) in 4 slots HT.
[15568] 10 Apr 08:06:53 - 0 clients connected (0 slaves), 568567 bytes in use, 0 shared objects

Reconnect logic threadsafe?

I'm curious if the reconnect logic for the redis gem is threadsafe. It seems like their could be a race condition if 2 threads try to reconnect at the same time and one does the disconnect between the others connect and write. We are occasionally seeing the following traceback:

A NoMethodError occurred in resque#overview:
 undefined method `write' for nil:NilClass
[RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:60:in `process'
 /opt/jruby-1.5.1/lib/ruby/1.8/monitor.rb:191:in `mon_synchronize'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:274:in `synchronize'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:279:in `ensure_connected'
 [RAILS_ROOT]/lib/redis_extensions.rb:9:in `ensure_connected'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:278:in `ensure_connected'

My monkey-patched /lib/redis-extensions just adds EBADF to the caught exceptions. We were seeing occasionaly EBADF errors even after setting the idle timeout to 0 (any chance this change could make it to the next release?):

require 'redis/client'

class Redis
  class Client
    def ensure_connected
      connect unless connected?

      begin
        yield
      rescue Errno::ECONNRESET, Errno::EPIPE, Errno::ECONNABORTED, Errno::EBADF
        if reconnect
          yield
        else
          raise Errno::ECONNRESET
        end
      end
    end
  end
end

When we see the above errors, we often see the following errors around the same timeframe. This part has me baffled but since they tend to occur within minutes of each other, I believe it's related:

A ConcurrencyError occurred in resque#overview:
 No message available
/opt/jruby-1.5.1/lib/ruby/1.8/monitor.rb:240:in `mon_acquire'
 /opt/jruby-1.5.1/lib/ruby/1.8/monitor.rb:166:in `mon_enter'
 /opt/jruby-1.5.1/lib/ruby/1.8/monitor.rb:165:in `mon_enter'
 /opt/jruby-1.5.1/lib/ruby/1.8/monitor.rb:189:in `mon_synchronize'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:274:in `synchronize'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:279:in `ensure_connected'
 [RAILS_ROOT]/lib/redis_extensions.rb:9:in `ensure_connected'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:278:in `ensure_connected'
 [RAILS_ROOT]/vendor/gems/redis-2.0.2/lib/redis/client.rb:59:in `process'

ZREM does not work, but zrem does ...

when i try to use ZREM i get
Redis.new.ZREM 'y', 'x'
Errno::EAGAIN: Resource temporarily unavailable - Timeout reading from the socket
from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:469:in read_reply' from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:444:inprocess_command'
from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:442:in map' from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:442:inprocess_command'
from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:431:in raw_call_command' from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:452:incall'
from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:452:in maybe_lock' from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:428:inraw_call_command'
from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:332:in call_command' from /usr/local/lib/ruby/gems/1.8/gems/redis-1.0.4/lib/redis/client.rb:381:inmethod_missing'

same call with zrem works...

WITHSCORES on ZRANGE, etc.

Would be nice if the lib provided the option to do various zset operations using WITHSCORES, or perhaps even by default for WITHSCORES to be used...

open connection timeout

We had an outage due to redis calls not timing out (in a timely fashion) here. Since that call opens the connection it probably deserves a timeout, no? Possibly relatedly, what's the current purpose of Redis::Timer? Would you be interested in a patch to add a timeout to TCPSocket.new?

push tags of releases

Hey Ezra,

Will be great if the tags for the gem releases were pushed, so we can use branch list of GitHub to figure out the list of changes ;-)

Thank you

Redis.connect overrides options

Hi, I've noticed that Redis.connect overrides options with the attributes parsed from url. Perhaps the operator should be changed to ||= ?

The problem I'm encountering is with Redis::Distributed. It calls Redis.connect when instantiating the HashRing. If any options are passed, Redis.connect ignores them. Maybe I'm missing something?

Thanks!

mget regression?

Formerly, one could use this:

require 'redis'

redis = Redis.new

redis.set("k1", "v1")
redis.set("k2", "v2")

kz = ["k1", "k2"]
kvz = redis.mget(kz)

puts kvz.inspect

And get ["v1","v2"]

Now it return nil - what gives?

It seems now if you want to use mget you have to pass all keys as arguments, e.g.
mget("k1", "k2") ?

Why the regression / deprecation ?

llrange on empty list

I dont know if this is a bug or a feature, but redis.rb v2 behaves differently on empty lists than v1:

     ruby-1.8.7-p249 > gem "redis", "~>1.0.1"
 => true 
ruby-1.8.7-p249 > require 'redis'
 => true 
ruby-1.8.7-p249 > Redis::VERSION
 => "1.0.7" 
ruby-1.8.7-p249 > r = Redis.new
 => #<Redis::Client:0x1023f3c40 @host="127.0.0.1", @pubsub=false, @db=0, @binary_keys=nil, @logger=nil, @password=nil, @sock=nil, @timeout=5, @thread_safe=nil, @port=6379> 
ruby-1.8.7-p249 > r.lrange "testlist", 0, -1
 => [] 
ruby-1.8.7-p249 > r.llen "testlist"
 => 0
ruby-1.8.7-p249 > exit
[11:32 AM:redisk(master)] $ irb
ruby-1.8.7-p249 > gem "redis", "~>2.0.1"
 => true 
ruby-1.8.7-p249 > require 'redis'
 => true 
ruby-1.8.7-p249 > Redis::VERSION
 => "2.0.1" 
ruby-1.8.7-p249 > r = Redis.new
 => #<Redis:0x1023d9a70 @client=#<Redis::Client:0x1023d99d0 @db=0, @host="127.0.0.1", @sock=nil, @password=nil, @logger=nil, @timeout=5, @port=6379> 
ruby-1.8.7-p249 > r.lrange "testlist", 0, -1
 => nil 
ruby-1.8.7-p249 > r.llen "testlist"
 => 0 

I have some code that expects lrange to always return an Array. Easy to fix on myside, but curious if it shouldnt be compatible with the way ~>1.0 handled it.

hash_ring.rb returns index -1

Hi,

I noticed the binary_search function sometimes returns -1. This occurs when 'value' is lower than ary[0].

I modified and added this:

end
if upper < 0
upper = ary.size - 1
end
return upper
end

Calling a command with wrong params breaks the subsequent commands

It seems the command params aren't cleared from some kind of buffer after an error.

For example: If you connect to redis from irb, run the info command, then run another command, say zrank but only pass it one arg, then the subsequent call gets messed up. i.e. if you tried to recall info, it would fail.

irb(main):001:0> require 'rubygems'
=> true
irb(main):002:0> require 'redis'
=> true
irb(main):003:0> r = Redis.new
=> #<Redis::Client:0x5e6870 @binary_keys=nil, @password=nil, @logger=nil, @sock=nil, @timeout=5, @PORT=6379, @thread_safe=nil, @host="127.0.0.1", @PubSub=false, @db=0>
irb(main):004:0> r.info
=> {:changes_since_last_save=>"154", }
irb(main):007:0> r.zrank 'gbgb'
RuntimeError: -ERR unknown command 'zrank'
irb(main):008:0> r.info
RuntimeError: -ERR unknown command 'gbgb' OOPS!

Occasional protocol error when using with threads

I'll have a look at your code and see if it's supposed to be thread safe.

If it's not intended to be then disregard. I'll just synchronize the object myself.

Here's the error if it helps:
Protocol error, got '6' as initial reply byte

This is from JRuby btw, might get a diff error on MRI.

Remove reliance on method_missing

I wrote out a branch to remove the reliance on method missing as it was causing a lot of problems for us, primarily when running rails specs (get and delete are already defined), so rather than write more methods like the #type and #exec methods I looped through all the methods and defined them.

http://github.com/dougcole/redis-rb/commits/remove_method_missing

If this isn't something you're interested in merging can we at least add a #get and #delete method so redis-rb plays nice with rspec?

@sock.close raises Errno::ECONNRESET

I'm using d14c202 on freebsd. I get this error:

    Errno::ECONNRESET: Connection reset by peer
    /usr/local/lib/ruby/gems/1.8/gems/redis-0.1/lib/redis.rb:192:in `close'
    /usr/local/lib/ruby/gems/1.8/gems/redis-0.1/lib/redis.rb:192:in `call_command'
    /usr/local/lib/ruby/gems/1.8/gems/redis-0.1/lib/redis.rb:178:in `method_missing'

The code is
def call_command(argv)
@logger.debug { argv.inspect } if @logger

        # this wrapper to raw_call_command handle reconnection on socket
        # error. We try to reconnect just one time, otherwise let the error
        # araise.
        connect_to_server if !@sock

        begin
          raw_call_command(argv.dup)
        rescue Errno::ECONNRESET, Errno::EPIPE, Errno::ECONNABORTED
          @sock.close # 192
          @sock = nil
          connect_to_server
          raw_call_command(argv.dup)
        end
      end

multibyte chars consider

counting bytes rather than chars..
(for ruby 1.9)
line 194
#argv[-1] = bulk.length
argv[-1] = bulk.bytes.count

Add Gemspec to github repo

Could you add the redis-rb gemspec to the github repo. That way you can use the github version of redis-rb in your Gemfiles with bundler.

"proc without block" problems with sinatra and padrino

Apparently because sinatra's application class (and/or padrino's router class) magically mixes in methods with common names like 'set' and 'delete', it causes all kinds of problems. What happens is that the method_missing method in redis.rb ends up delegating redis commands to sinatra!

I added explicit 'set' and 'delete' methods in redis.rb (see my fork) to get around this. I haven't fully tested every redis command after my modifications to check for other possible collisions.

Subscription class polluting main namespace

I have a rails app running resque and the redis gem overrides my ActiveRecord model named 'Subscription'. Can the 'Subscription' class in lib/subscribe be namespaced inside of a class or module so it doesn't cause conflicts with Base classes?

Example of pipelining

Would be super great to have code example demonstrating the use of pipelining.

Thanks,

marc

r.keys should retrurn an array

prior to 2.0, r.keys(pattern) returned the matching keys as an array. now it returns a single, blank separated string.

This new behavior breaks our beetle gem. We could work around it, but I consider this as a bug, as keys with embedded blanks seem to be supported by redis.

EBADF errors

We recently converted our MRI rails app to JRuby. After running a couple of days, we started getting multiple EBADF - Bad File Descriptor errors. We pass threadsafe on new and the redis server hasn't bounced. We're running redis 1.0.7, Rails 2.3.2 and JRuby 1.5.1. Any advice on what the cause is or what I can do to investigate the cause?

A Errno::EBADF occurred in admin#load_widget:
Bad file descriptor - Bad file descriptor
[RAILS_ROOT]/vendor/gems/redis-1.0.7/lib/redis/client.rb:452:in process_command' [RAILS_ROOT]/vendor/gems/redis-1.0.7/lib/redis/client.rb:442:inraw_call_command'
[RAILS_ROOT]/vendor/gems/redis-1.0.7/lib/redis/client.rb:461:in maybe_lock' [RAILS_ROOT]/vendor/gems/redis-1.0.7/lib/redis/client.rb:439:inraw_call_command'
[RAILS_ROOT]/vendor/gems/redis-1.0.7/lib/redis/client.rb:343:in call_command' [RAILS_ROOT]/vendor/gems/redis-1.0.7/lib/redis/client.rb:392:inmethod_missing'
[RAILS_ROOT]/app/controllers/admin_controller.rb:285:in `load_widget'

1.0?

This gem is awesome and production ready - can we get a 1.0?

Semantic Versioning would be a nice bonus, but I'll take what I can get ;)

Interested in simple connection pool?

Mostly we run under thin, but we do have a threaded job server. Found the :thread_safe option but really need a pool. Right now we're basically making our own "pool" by creating a connection per job class, but that's getting a bit crazy.

I was thinking

Redis.new(:host => 'localhost', :pool => 10)

The :pool option would imply :thread_safe. Looking through the code, it seems like a pretty straightforward patch to maybe_lock()

Just wanted to check on what you thought about this approach before jumping into implementation

Thanks,
Nate

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.