The insights-results-aggregator-cleaner's discuss from redhatinsights

New gosec-related issue detected

[/home/tester/ccx/insights-results-aggregator-cleaner/cleaner.go:138-143] - G307 (CWE-703): Deferring unsafe method "Close" on type "*os.File" (Confidence: HIGH, Severity: MEDIUM)
    137:        }
  > 138:        defer func() {
  > 139:                err := file.Close()
  > 140:                if err != nil {
  > 141:                        log.Err(err).Msg("File close failed")
  > 142:                }
  > 143:        }()
    144:

database.go:269:10:1 other occurrence(s) of "cluster" found in: database.go:176:18

Function with zero code coverage detected: cleaner.go:100: IsValidUUID

Ability to display version info when CLI option is used

Document this service in internal documentation

Make gosec installation verbose

Make gosec installation verbose to detect installation errors

cleaner.go:92:42:1 other occurrence(s) of "Not a proper cluster ID" found in: cleaner.go:138:39

cleaner.go:97:73:3 other occurrence(s) of "Cluster list finished" found in: cleaner.go:96:71 cleaner.go:142:71 cleaner.go:143:73

Possible error in shell script

In bdd_tests/run_tests.sh line 7:
    virtualenv -p python3 venv && source venv/bin/activate && python3 `which pip3` install -r requirements.txt
                                                                      ^-- SC2046: Quote this to prevent word splitting.
                                                                      ^-- SC2006: Use $(..) instead of legacy `..`.

Prepare unit tests for the cleaner

Rename `database.go` to `storage.go` for better consistency with other Insights repositories

Rename database.go to storage.go for better consistency with other Insights repositories

cleaner.go:142:17:1 other occurrence(s) of "number of clusters to delete" found in: cleaner.go:96:17

cleaner.go:96:71:3 other occurrence(s) of "Cluster list finished" found in: cleaner.go:97:73 cleaner.go:142:71 cleaner.go:143:73

Add package manifest into documentation

database.go:263:10:1 other occurrence(s) of "table" found in: database.go:268:10

Ability to display authors when CLI option is used

cleaner.go:142:71:3 other occurrence(s) of "Cluster list finished" found in: cleaner.go:96:71 cleaner.go:97:73 cleaner.go:143:73

Ability to display actual configuration when CLI option is used

Figure out which environment variables are used on CI

Bump-up Go version to 1.16 on CI

cleaner.go:90:41:1 other occurrence(s) of "Proper cluster ID" found in: cleaner.go:136:38

cleaner.go:90:19:3 other occurrence(s) of "input" found in: cleaner.go:92:20 cleaner.go:136:19 cleaner.go:138:20

Ability to figure out which clusters have the same rule(s) disabled by different users

database.go:176:18:1 other occurrence(s) of "cluster" found in: database.go:269:10

Fix all minor issues found by linters

Go 1.13 is no longer supported, it is needed to bump-up the version

https://golang.org/doc/devel/release.html

cleaner.go:143:73:3 other occurrence(s) of "Cluster list finished" found in: cleaner.go:96:71 cleaner.go:97:73 cleaner.go:142:71

cleaner.go:138:39:1 other occurrence(s) of "Not a proper cluster ID" found in: cleaner.go:92:42

Ability to run behavioral tests from Makefile (as a target)

cleaner.go:97:17:1 other occurrence(s) of "improper cluster entries" found in: cleaner.go:143:17

Install gosec the official way - through binaries

Add Table of Content into the README.md file

cleaner.go:138:20:3 other occurrence(s) of "input" found in: cleaner.go:90:19 cleaner.go:92:20 cleaner.go:136:19

Ensure that cloud.redhat.com address is not wired in the code

Update to newer gosec version

Possible error in shell script

In bdd_tests/run_tests.sh line 12:
PYTHONDONTWRITEBYTECODE=1 python3 "`which behave`" --tags=-skip -D dump_errors=true @feature_list.txt $@
                                   ^-- SC2006: Use $(..) instead of legacy `..`.
                                                                                                      ^-- SC2068: Double quote array expansions to avoid re-splitting elements.

redhatinsights / insights-results-aggregator-cleaner Goto Github PK

insights-results-aggregator-cleaner's Issues

Recommend Projects

Recommend Topics

Recommend Org