reddragonwebdesign / adblock-filter-analyzer Goto Github PK

AdBlock Filter Syntax code highlighter and partial validator. Colorizes and explains the syntax. Good for learning.

Home Page: https://www.reddragonwebdesign.com/projects/adblock-filter-analyzer/

JavaScript 82.03% Hack 13.78% CSS 4.19%

adblock ublock-origin javascript adblock-plus ublock adblocker adblock-list adblocking syntax-highlighter syntax-analysis

adblock-filter-analyzer's People

Stargazers

Watchers

Forkers

tueksta

adblock-filter-analyzer's Issues

exceptionRegEx is showing as domainRegEx

double space in rich text editor creates an  , need to replace that with space and vice versa

richTextBox undo behavior is buggy

paste good tests
select all, paste bad tests over it
add a space to a random word
hit ctrl-z (undo). space is not deleted.
hit ctrl-z a couple more times. the good tests text comes back, but appended to the end of the bad tests list

bad filter list - mismatches

mismatches always indicate a bug. example filters:

@@/test/,/test2/##hello

xmlhttp warning in devtools: "synchronous xmlhttprequest on main thread is deprecated"

<textarea> is rendering as a textarea in rich text box

typing any syntax on a new line (2nd line for example) fails to highlight it

Ctrl-A then paste is slow. Consider having JS delete all text, then do the paste

finish incorporating Code Review suggestions

https://codereview.stackexchange.com/a/245136/40303

LineCount = 2 when richTextBox is empty

display error hint in definition box

###test showing up as `comment` instead of `selector`

turn off v-scroll, I find myself scrolling around the window too much

extra enter when importing a file

parse "include" type directives, load their contents into the file

hitting enter then typing types in the old spot - bad cursor position when hitting enter

update index.php, get rid of input box, also re-title to emphasize explaining over validating

rich text paste, tab is not rendering correctly

I fixed some of this, but the first tab still gets converted to a space on paste.

support for #$?# - agCSSInjection

ubo syntax checker says it's valid. Example:

bowandtie.ru#$?#.social-likes { remove: true; }

The list AdGuard Social Media has 7 or 8 of these

https://kb.adguard.com/en/general/how-to-create-your-own-ad-filters#syntax-3

Changing it to #?# or ## makes it invalid in syntax checker. So it needs its own category.

2 mismatches on test-bad-filters.txt list

Example: /^https://www\.narcity\.com/assets/[0-9a-f]{24,}\.js/$script

millisecond timer

integrate with main website

Header and footer should be present.

add a dropdown list that loads external files, including my tests and major lists

tooltips.php - uncaught syntaxerror: unexpected token 'export'

Import still works though. Going to ask on Reddit.

rich text cursor position

// window.getSelection()
// may need to use draftJS library
// check JQuery and Bootstrap for WYSIWYG editors

double dollar sign getting eaten up, i.e. # test -> $$()

tooltips for specific $options, +js(), domain special chars, pre processing directives, action operators, cosmetic filters

profile and optimize

typing adds a space at the end every time you add a letter

add # of lines to index.php

Pasting an open tag into richTextBox will result in it adding a </closingTag> on the last line

Example:

#<shock-sites>
blahblah

Will add </shock-sites> at the end of the file

can't press enter if you are at the last spot in the text box

when picking new filter list from combo box, carat does not go to position 0

hitting enter at end places two enters

sometimes. may need to hit enter two or three times to replicate. seems to be happening every other time

tooltips

// TODO: tooltips
// check for JQuery and Bootstrap tooltips

hitting backspace at end does not work

many /##/ style filters are parsing wrong

Not all of these, but most of them

/^https:\/\/([a-z]+\.)?sythe\.org\/\[=%#@$&!^].*[\w\W]{20,}/$image
/##/
/##^/
/@@/
/test$/
/#@#/
/#@#^/
/#?#/
/:style/
/##+js/
/#@#+js/

optimize speed, so it isn't too slow for big lists

currently gets slow if more than about 500 filters

maybe getting rid of the JSON/tree will speed things up

profile with devtools -> performance tab and see if there's any slow algorithms

add support for showing if filter is generic or specific

https://help.eyeo.com/en/adblockplus/how-to-write-filters#generic-specific

ok for lines to have space & tab at the end

! ok for lines to have whitespace at the end: space, tab
test.com  
worldofbitco.in##+js(set, adBlock, false)

Will probably need to add this.syntax['whitespaceFront'] and this.syntax['whitespaceBack']

break richtextbox off into its own project/class/module, after all the bugs are fixed

For one of the bugs, I'm going to have to keep track of the last input before the current input in a variable. That kind of stuff should be handled by the class, invisible to the user.

Same with fixing the cursor.

typing space at beginning of line doesn't render correctly. needs  

tooltips for RegEx, CSS selectors, CSS properties, ABP snippets

throw errors for things like double action operators, double ## #?#

! per ublock documentation
example.com##+js()

! can't have things twice
example.com##test#?#test:style(position: absolute !important;)
example.com#?#test##test:style(position: absolute !important;)
example.com##test:style(position: absolute !important;):style(position: absolute !important;)
example.com#?#test:style(position: absolute !important;):style(position: absolute !important;)
example.com##test#@#test
example.com##test#?#test
example.com#?#test##test

! action operators :style() and :remove() are not allowed to be applied in many cases
example.com##^.badstuff:style(position: absolute !important;)
example.com##^.badstuff:remove(position: absolute !important;)
example.com#@#^.badstuff:style(position: absolute !important;)
example.com#@#^.badstuff:remove(position: absolute !important;)
example.com#@#.badstuff:style(position: absolute !important;)
example.com#@#.badstuff:remove(position: absolute !important;)
tribunnews.com##+js(acis, Math, ='\x):style(position: absolute !important;)
test.com$websocket:style(position: absolute !important;)
audiofanzine.com#$#abort-on-property-read TextDecoder:style(position: absolute !important;)

test outgoing copy/paste, make sure the text is correct

Ctrl-A then paste sometimes messes up the last line, puts a space

May only happen when there's an enter at the end of the file. It replaces the enter with a space.

Ctrl-A, Ctrl-V

||smsy24.pl^$document

finish adding tooltips and writing out existing tooltips

json and tooltip should display whether it's a static or dynamic filter

noop = request not subject to dynamic filtering, but static filters still apply
allow = request not subject to dynamic and static blocking
https://github.com/gorhill/uBlock/wiki/Dynamic-filtering:-rule-syntax#actions:
https://github.com/gorhill/uBlock/wiki/Overview-of-uBlock's-network-filtering-engine
https://github.com/gorhill/uBlock/wiki/Overview-of-uBlock's-network-filtering-engine:-details

paste big lists into validator as a test

css and +js() can have $ sign, should not trigger error

mac-torrent-download.net##+js(acis, $, AdBlock)
watchmygf.me##+js(set, $.magnificPopup.open, noopFunc)
run.az#?#div[class$="bolmem"]

reddragonwebdesign / adblock-filter-analyzer Goto Github PK

adblock-filter-analyzer's People

Stargazers

Watchers

Forkers

adblock-filter-analyzer's Issues

Recommend Projects

Recommend Topics

Recommend Org