Coder Social home page Coder Social logo

Secret callback about baseplate.go HOT 5 CLOSED

reddit avatar reddit commented on July 17, 2024 3
Secret callback

from baseplate.go.

Comments (5)

fishy avatar fishy commented on July 17, 2024 1

I like the channel idea. Just two things to note:

  1. We shouldn't change NewStore because most of the use cases doesn't need the callback. We can create a new one like NewStoreWithCallback
  2. The notify <- secrets should probably be in its own goroutine, otherwise if the caller didn't read from the channel timely, this would block the parser.

from baseplate.go.

konradreiche avatar konradreiche commented on July 17, 2024

What does a downstream client mean? Is that a client implementation you are providing yourself outside of baseplate.go?

from baseplate.go.

fishy avatar fishy commented on July 17, 2024

What does a downstream client mean? Is that a client implementation you are providing yourself outside of baseplate.go?

Yes.

from baseplate.go.

andizzle avatar andizzle commented on July 17, 2024

This is addressed by #20

from baseplate.go.

fishy avatar fishy commented on July 17, 2024

We still need to allow registering of middlewares after initialization, but that can be in its own ticket.

from baseplate.go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.