Comments (2)
This is not dead code. This is a deferred function with named return. err
will be whatever error
baseplate.go/thriftbp/client_pool.go
Line 371 in b288626
from baseplate.go.
Yeah, I see. Sorry 😐.
from baseplate.go.
Related Issues (20)
- Upgrade go-redis to a non-beta version HOT 1
- Easier to use mock secrets store
- Add a method for creating test thrift servers, similar to httptest.NewServer
- Add an io.Closer implementation that closes a collection of closers
- Add standard test EdgeRequestContexts HOT 1
- Users bucketing into experiments not working
- `retrybp.NetworkErrorFilter` would also return true for `context.DeadlineExceeded`
- `thriftbp.ClientPool` should not implements `thrift.TClient`
- Remove deprecated stuff
- Remove the `Config` types that's solely for yaml parsing
- Change `log.Wrapper.UnmarshalText` to use `ErrorWithSentryWrapper` as the default one HOT 1
- Enable strict yaml parsing
- Update redisbp to use v8 of go-redis HOT 1
- Add Prometheus metrics endpoint
- Move experiments package to its own repo HOT 1
- thrifttest.NewBaseplateServer should accept an ecinterface.Interface
- Prometheus `${protocol}_success` label has different behavior depending on the protocol HOT 3
- Reason for suffix 'bp' behind packages name.
- Provide an effective configuration file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baseplate.go.