redcrewos / open-qr-standard Goto Github PK

In the profile documents (eg: Core, POS, etc), the version of JSON Schema referenced in the standard is draft-bhutton-json-schema-00 (known as draft-2020-12). However the value of $schema in the schema definitions are for a previous version ie: draft-07. This leads validation tools (eg: ajv) to use the draft-07 version of the JSON Schema standard which means if the profile schema definitions were ever to include a feature from the draft-2020-12 version, validators may not accept the schema/throw errors.

The solution is to namespace/align the schema documents to the version specified by the standard

$schema: "https://json-schema.org/draft/2020-12/schema"

Happy to do the PR if that would be helpful.

Currently for the Point-of-sale Payment Profile the instrument that is provided has a type that is then the URN of an applicable payment instrument, defined by a profile and supported by the Code Provider eg: urn:cds-au:qr:pos-instrument:eftpos:1

However it would better to have an instruments block where the keys are the URN and the values are the data that is required by that instrument type/URN's schema.

This would be consistent with how the profiles are defined in the Core Profile and would facilitate scenarios where multiple instruments could be provided (eg: gift cards and a credit card).

Currently the standards have JSON schemas for other parts of the profile. It would be good to have the Discovery documents in JSON schames as well as the tables. This would facilitate validation of documents that are interchanged as part of the discovery process.

Having read through the standard a couple of times, it's not clear what a "session" is. Specifically, what comprises a session, and what does it mean to claim a session. If I was implementing a Code Producer I'm not clear on what I would have to record in my system.