recruit-tech / agreed-ui Goto Github PK

• prop-types and axios seem used only under src/component directory, and therefore they don't need to be dependencies. (They can be dev dependencies.)
• If we move them to dev deps, that reduces the installation size and saves the user's disk space.

npm install doesn't work on this project.

npm install

installation fails and i'm getting this error.

npm ERR! code E404
npm ERR! 404 Not Found: [email protected]

APIの複数パターンで仕事で利用させていただいてます。

概要

同一URLかつ 同一メソッドの正常系、異常系のパターンを記述していくと数が多くなり、
UI上煩雑になりがちなので、グルーピングできるようになるとありがたいです。

ソート順を考え出すとややこしいので、
正常系、異常系 の順に並んでいたら もっと嬉しいです。

If the agree files contains $' in string literal, then built html gets broken.

This is caused by the expression

html.replace(`"${'__AGREES__'}"`, serialized)

in https://github.com/recruit-tech/agreed-ui/blob/master/scripts/build.js

If the serialized contains $', then it is interpreted as RegExp.rightContext and replaced as the right context of matched string.