reckziegel / ffp Goto Github PK

Review the entropy_pooling function to speed up computations and memory usage.

Even if entropy_pooling() works fine, the function is still shy in the package as a whole. Maybe if there were constructors for the views, this function could have a central spot here and in the CMA (#6).

The difference between ts and mts can pave the way for subtle bugs. Example:

colnames(EuStockMarkets)
#> [1] "DAX"  "SMI"  "CAC"  "FTSE"
names(EuStockMarkets)
#> NULL
is.mts(EuStockMarkets)
#> [1] TRUE
is.ts(EuStockMarkets)
#> [1] TRUE

colnames(EuStockMarkets[ , 1])
#> NULL
names(EuStockMarkets[ , 1])
#> NULL
is.mts(EuStockMarkets[ , 1])
#> [1] FALSE
is.ts(EuStockMarkets[ , 1])
#> [1] TRUE

colnames(EuStockMarkets[ , 1, drop = FALSE])
#> [1] "DAX"
names(EuStockMarkets[ , 1, drop = FALSE])
#> NULL
is.mts(EuStockMarkets[ , 1, drop = FALSE])
#> [1] FALSE
is.ts(EuStockMarkets[ , 1, drop = FALSE])
#> [1] TRUE

^{Created on 2021-07-01 by the reprex package (v2.0.0)}

Something like this would be nice. Also, add an argument to group prior and posterior margins and inspect the differences among them.

library(ggplot2)
library(ggdist)
library(tibble)
pnl <- diff(log(EuStockMarkets[ , 1, drop = TRUE]))
pnl <- as.double(pnl)
tibble(pnl = pnl) %>% 
  ggplot(aes(x = pnl)) + 
  stat_histinterval(breaks = 100, outline_bars = TRUE) 

^{Created on 2021-06-15 by the reprex package (v2.0.0)}

Create a method that binds different views into the same object,

Bind_probs() could be improved to display a prettier output, possibly using information from the user call.

Check if stats::constrOptim can be used for constrained optimization. If so, two dependencies could be eliminated (pracma and NlcOptim).

Prepare for release:

• Check current CRAN check results
• Polish NEWS
• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• revdepcheck::revdep_check(num_workers = 4)
• Update cran-comments.md
• Review pkgdown reference index for, e.g., missing topics
• Draft blog post

Submit to CRAN:

• usethis::use_version('minor')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()
• Finish blog post
• Tweet
• Add link to blog post in pkgdown news menu

Prepare for release:

• git pull
• Check current CRAN check results
• Polish NEWS
• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• revdepcheck::revdep_check(num_workers = 4)
• Update cran-comments.md
• git push

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• git push
• usethis::use_github_release()
• usethis::use_dev_version()
• git push

It would be nice to centralize flexible probabilities functionality in just one place. Bring CMA to the package may be interesting.

Prepare for release:

• Check current CRAN check results
• Polish NEWS
• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()
• revdepcheck::revdep_check(num_workers = 4)

• Rstudio message: package ‘revdepcheck’ is not available for this version of R.

• Update cran-comments.md

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()

First release:

• usethis::use_cran_comments()
• Proof read Title: and Description:
• Check that all exported functions have @returns and @examples
• Check that Authors@R: includes a copyright holder (role 'cph')
• Check licensing of included files
• Review https://github.com/DavisVaughan/extrachecks

Prepare for release:

• devtools::build_readme()
• urlchecker::url_check()
• devtools::check(remote = TRUE, manual = TRUE)
• devtools::check_win_devel()
• rhub::check_for_cran()

Submit to CRAN:

• usethis::use_version('patch')
• devtools::submit_cran()
• Approve email

Wait for CRAN...

• Accepted 🎉
• usethis::use_github_release()
• usethis::use_dev_version()
• Update install instructions in README

Standardize the kind of inputs the package accepts; otherwise, it's necessary to go back and forth between different data structures, making it easy to break the code.