rebolon / apijsonparamconvertercomponent

ParamConverter to build entities from json string catched in Request (#symfony, #api-platform)

Hi there 👋

• 🔭 I’m currently working at Sogexia
• 🌱 I’m currently improving my skills on Angular and RxJS
• I try to improve my Lead Developer skills

Bio

Keen on web development, i practice a lot of PHP over different frameworks like symfony or copix. Even if i also did some #dotNet, #java or #coldfusion, i liked workgin with #meteorjs (a so cool #nodejs platform for server-side Javascript). Front-end is also a new part of my job with #VueJS (v2... not started on v3) and #Angular (v2...16).

In 2014 i did a talk about meteor at #LyonJs organization (in french https://youtu.be/ncLUaIDmCDk?t=1045) , and since the #worldwidemeteorday i leaded a #meteorjs #meetup group in #Lyon for 3 years.

In 2015 i did a talk at the great #BlendWebMixconference in #Lyon with the following subject : Going faster with MeteorJS (in french https://www.youtube.com/watch?v=6f7d_6VgiEM).

And in 2016 i did a talk on #VueJS at #BlendWebMixconference in #Lyon (in french https://www.youtube.com/watch?v=3-pt-7U2pNg).

I'm not a core contributor to open-source, but i try to help them when i can. You can find some of my contributions in symfony (code and docs), but also apiPlatform (mostly issues), clarity from VMWare ...:

• https://symfony.com/contributors/code
• https://symfony.com/contributors/doc
• https://connect.symfony.com/profile/rebolon
• https://clarity.design/community

If you have a project, contact me, i'm sure i may help you.

Except my work, i'm keen on bicycle (road for speed and mountain bike for nature) and i started small ultra races with the Gravelman Series (350km, ~4000 - 7500D+, in full autonomy). And finally i really love my family and my 3 beautiful daughters that support me all day long.

apijsonparamconvertercomponent's Issues

Use ConstraintViolationListNormalizer to throw 400 when validations errors happened

More information here:
https://symfony.com/blog/new-in-symfony-4-1-serializer-improvements?utm_source=Symfony%20Blog%20Feed&utm_medium=feed

Should i manage Update operation ?

For instance, only Insert operation are allowed. Why ?
Because the ParamConverter is only allowed to restore valid Entities. And it considers that if there is an identifier property (id by default), it must retreive the real entity from database.
So it cuts all other fields and use database information.

But there is 2 problems:

• ParamConverter should not take care at data consistency except rules defined in Specific ParamConverter (fields name, related converter...). If a user send data with id, ParamConverter should restore a valid entity with all information provided on HTTP call
• If we send ID on the root element, ParamConverter will not take care at anything else but the ID, so it will just retreive the main Entity from database and return it to the Controller.

The question would be: what is the expected behavior ?
should we provide different ParamConverter ? one for Insert, one for Update ?
when there is ID, should we retreive from database, and then apply modification from json ? but in that case for all properties undefined in Json, should we set them to null in retreived Entity ? and for properties that are list of entities (for the repsresentation of associative table) should we remove existing entries and add those defined in Json ? Because when we retreive information from database, don't forget that Doctrine will manage relations so it might add new relations

Use Symfony Serializer to denormalize item

It should be better than doing it by myself.
I will just need to keep the deduplication system that is the keypoint of this package

root node in json should not be mandatory

For instance for a Book i must have a root book node like this:

{ 
  book: {
    ...
  }
}

This is useless and so it should be optional ! (ApiPlatform with Denormalizer doesn't need this root node)