Consider making reducer run before mutations. about reactorkit

[seivan]

Alright, I think we see this differently. From my PoV it's irrelevant what alters the state.
showing a loading spinner is exactly the same thing as setting a list of tasks.
They both update the UI that's subscribed to the state.

But I'll just maintain this notion myself! Thanks for the code example on canceling, that's useful!

[devxoul]

In that case it's recommended to use both Action and Mutation. Action is just an abstraction of an user input from a view and a mutation is a state-manipulator.

enum Action {
  case requestTasks
}

enum Mutation {
  case setLoading(Bool)
  case setTasks([Task])
}

func mutate(action: Observable<Action>) -> Observable<Mutation> {
  switch action {
  case .requestTasks:
    return Observable<Mutation>.concat([
      Observable.just(.setLoading(true)), // .setLoading(true)
      fetchTasksUsingAPI().map { Mutation.setTasks($0) }, // .setTasks([...])
      Observable.just(.setLoading(false)), // .setLoading(false)
    ])
  }
}

You may refer to the actual code: https://github.com/devxoul/Drrrible/blob/f52812943d16a891ace62083adac753c2c30ac87/Drrrible/Sources/ViewControllers/ShotListViewReactor.swift#L44-L53

[seivan]

Yes, I understand that part. The problem is you're gong to get a lot of messy actions that don't do anything they than toggling visibility of components. Setting the loading spinner is part of loading the tasks. Not two different actions. Except one mutation is async and the other synchronous.

[seivan]

Btw, I figured out a way to handle the infinite loop problem That Redux-Observables have. Ensure type constraints on your "epic". T: Action -> U:Action where T != U.
That solves the :

"const actionEpic = (action$) => action$; // creates infinite loop"

[devxoul]

Setting the loading spinner is part of loading the tasks. Not two different actions.

There's one action and two mutations. It's not "two different actions". One action can occur multiple mutations.

And I didn't see anywhere that occurs infinite loop in ReactorKit. Could you reproduce it?

[seivan]

@devxoul No, the infinite loop is part of Redux-Observable issue :) not related here, sorry for the confusion!

Yeah but why does setting loading need its own action? As far as I see, those two things are related. There are other cases where you'd want an action to reduce state and async trigger a different action.

I really suggest looking into Redux-Observable, the strength comes from the ability to cancel async actions. https://redux-observable.js.org/docs/recipes/Cancellation.html

[devxoul]

Why do we have to expose an Action.requestTasksCompleted to a view? A view's interest is just an Action.requestTasks. Action and Mutation are different. Action just takes user inputs from a view and Mutation just manipulates the state. Their role are different from each other. Of course the Action.requestTasks and setLoading can be related but "setting loading" is not a role of an Action. I would like to separate the responsibility to reduce complexity.

And for cancellation, I think we can make actionSubject public. It may look like:

func mutate(action: Action) -> Observable<Mutation> {
  switch action {
  case .refresh:
    return Observable<Mutation>.concat([
      Observable.just(.setLoading(true)),
      API.requestTasks()
        .map { Mutation.setTasks($0) }
        .takeUnil(self.actionSubject.filter(Action.cancelRefreshing)),
      Observable.just(.setLoading(false)),
    ])
  }
}

I'll take a look at this for another solution 👀