Xcode 12 : PR 163 & WeakMapTable bug about reactorkit

[PierreBrisorgueil]

@dodgecm hum, thx for this information, i will try it soon, and I would give feedback to update the readme 👍

[PierreBrisorgueil]

probably linked to https://github.com/ReactorKit/ReactorKit/pull/138/files

[PierreBrisorgueil]

ref : #168

[PierreBrisorgueil]

Hello, quick conclusion on my tests, I allow myself to ping people who have discussed similar subjects

@kbw2204 @chihaodong @dodgecm @devxoul @tokijh

So, for xcode 12 / swift 5 migration we are facing two issues:

• swift package update
• WeakMapTable issue

based on my fork https://github.com/PierreBrisorgueil/ReactorKit/tree/fixUpgradeIosDeploymentTarget2

• after update swift package like this #163 for Xcode 12
• and revert this pr https://github.com/ReactorKit/ReactorKit/pull/138/files for WeakMapTable (I haven't found any other solution for PR, but I'm not an expert )

i'm facing this last issue :

transformedState.connect().disposed(by: self.disposeBag)
Thread 1: EXC_BAD_ACCESS (code=2, address=0x10ce6c450) (lldb) 

Reactor.swift

probably the last issue for xcode 12 migration, but not very competent, on this stuff i will try to understand.

related to : #140

[PierreBrisorgueil]

Ok, after a switch on last rxSwift 5.1.1 in project everything is ok.

So to be ready for xcode 12 i think we just need to accept #163 and resolve WeakMapTable issue.

I would try to look again at why the package is missing and causing problems. With carthage it seemed to be in the checkout directory without a problem, however once build the dependency is missing for ReactorKit in our project, really strange.

(ps: Xcode 12 carthage require Carthage/Carthage#3019)

[dodgecm]

Hi, my apologies for the slow response. In our Fastfile, we do:

    Dir.chdir("../Carthage/Checkouts/ReactorKit") do
      sh "swift package generate-xcodeproj --xcconfig-overrides ../../../Frameworks/ReactorKit.xcconfig"
    end
    Dir.chdir("../Carthage/Checkouts/WeakMapTable") do
      sh "swift package generate-xcodeproj --xcconfig-overrides ../../../Frameworks/WeakMapTable.xcconfig"
    end

The Carthage workaround documentation in ReactorKit should probably be updated to include this as well, but I didn't think to include it in my PR.