Comments (4)
Good catch! Indeed, table elements need special handling here.
For your second case, is that actually an issue? Tables should ideally always have at least one <tbody>
in them.
from react-magic.
Agreed. Injecting <tbody>
shouldn't be an issue in most cases.
Perhaps a note in the README to indicate elements aren't guaranteed to match 1:1?
from react-magic.
Daniel15, is this project ever going to be able to match HTML 1:1? Could you ever ensure a ~100% compatibility with HTML5? Does React/JSX have full coverage over everything you can do in normal HTML?
When I used this on a few sites, I would often get HTML syntax errors (akin to #9). Is that due to an incompatibility or just a buggy parser that could be fixed if enough time was put into it?
from react-magic.
@karlfloersch - What issues have you encountered? Concrete examples would be great, ideally one separate issue per issue to allow for better tracking 😄 JSX should allow most HTML tags except for deprecated tags, and hence the converter should also support them.
from react-magic.
Related Issues (20)
- Ability to preload links on hover, or expose enough of an API for users to implement. HOT 1
- Comparison to TurboLinks
- Getting hit with wall of errors HOT 3
- Convert hyphenated attributes into camelCase HOT 1
- [HtmlToJsx] View logic? F.e., how do we loop through items in an HTML view? HOT 2
- onclick attribute not getting renamed to onClick HOT 1
- Feature Request : Make this work in a web worker HOT 1
- HTMLtoJSX page is broken HOT 3
- HTML to JSX is broken HOT 5
- Autofocus isn't camel-cased HOT 2
- Change React.createClass to ES class
- feature request: serialize nodes and attributes to custom code
- HTMLtoJSX, better document default behavior
- SVG: incorrect gradientunits attribute
- complex style prop not parsed correctly
- White-space conversion on text nodes or inline elements HOT 2
- react 16 HOT 1
- Reactmagic site have "<" unexcpected error
- Add option to output Functional component (as well as import and export statement)
- ref value in react
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-magic.