HTML entities in text nodes returned as real HTML about react-magic

[ssorallen]

Related StackOverflow answers that explains why this happens: text nodeValue containing HTML entity

[ssorallen]

The simplest approach might be to escape ampersands in text passed to the converter:

> converter.convert("<code>&amp;lt;body&amp;gt;</code>")
"<code>&lt;body&gt;</code>
"

[Daniel15]

I used one weird trick to escape required symbols:

var tempEl = document.createElement('div');
function escapeSpecialChars(value) {
  // Uses this One Weird Trick to escape text - Raw text inserted as textContent
  // will have its escaped version in innerHTML.
  tempEl.textContent = value;
  return tempEl.innerHTML;
}

escapeSpecialCharacters('<'); // &lt;

Although I just realised this won't work exactly right in Node.js where I use JSDom, so I'll have to move stuff around a bit.

[ssorallen]

The fix works great in browser.

Are the past couple fixes worthy of a minor version release or a patch release?

[Daniel15]

Yeah I think I'll do a patch release, just want to wait a few days and see
if any other small bug fixes come up.

Regards,
Daniel Lo Nigro
http://dan.cx/ | Twitter http://twitter.com/Daniel15 | Facebook
http://www.facebook.com/daaniel

On Sat, Jan 10, 2015 at 12:13 PM, Ross Allen [email protected]
wrote:

The fix works great in browser.

Are the past couple fixes worthy of a minor version release or a patch
release?

Reply to this email directly or view it on GitHub
#11 (comment).