Comments (4)
@tesseralis Could you enlighten us here whether the findings of @Jacco are correct? And if so, what the best course of action is, besides his plan of action, to get back in sync again with the main translations?
from nl.reactjs.org.
I have watched the repositories for a few other languages and they get sync PRs (from a bot). We do not get those any more since feb 24. The sync bot automatically sends PRs with all commits in it. The bot will created a normal PR with all commits done on the original enlish versions. It creates a PR comment indicating which files need an extra look. It will look at which lines changed/add/deleted in the english version, and check if that is already translated, it will mention the problem files. The merge conflicts version based on line number. If the line numbers of the dutch and english version are not matching the merge conflicts will look crazy and are very hard to merge. I think we are not getting the sync PRs any more because the bots sees that the number of lines of the file is different to start with. It can't generate a commit, that is easy to merge then.
We should have never accepted any PR where the number of lines of the article changes.
I have checked every PR. This are some PRs that has a different in line count:
#28 1230 -> 1246
Ah, but that PR ws not merged into master. I will keep looking.
Starting with the last merged sync PR:
There is be a problem with a merge commit:
problem
The number of lines is suspicious here:
I also looked at PRs before the last sync. The following PRs all have linecount differences:
#10
#11
#13
#16
#17
#19
#20
#21
These PRs were all merged. We need to fix the number of lines for all of those. Otherwise the bot system will never start again.
We also need to check for inconsistencies in extra commits done to merged sync PRs I am afraid:
I checked all and the only problem seems to be in the commit I mentioned above.
from nl.reactjs.org.
It might be the case that linefeeds do not matter, but I also saw some occurrences of notes where a linefeed was added inside a note, but the extra line did not have a >, meaning it would create two note sections.
Maybe our repo is no longer merged because it is not compliant for that reason?
The guess then would be that we no longer get synced because we are not merged.
from nl.reactjs.org.
Closing
from nl.reactjs.org.
Related Issues (8)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nl.reactjs.org.