reactioncommerce / api-plugin-carts

Carts plugin for the Reaction API

This repository is deprecated

This code is now located in our monorepo here

api-plugin-carts

Summary

Carts plugin for the Reaction API

Developer Certificate of Origin

We use the Developer Certificate of Origin (DCO) in lieu of a Contributor License Agreement for all contributions to Reaction Commerce open source projects. We request that contributors agree to the terms of the DCO and indicate that agreement by signing all commits made to Reaction Commerce projects by adding a line with your name and email address to every Git commit message contributed:

Signed-off-by: Jane Doe <[email protected]>

You can sign your commit automatically with Git by using git commit -s if you have your user.name and user.email set as part of your Git configuration.

We ask that you use your real name (please no anonymous contributions or pseudonyms). By signing your commit you are certifying that you have the right have the right to submit it under the open source license used by that particular Reaction Commerce project. You must use your real name (no pseudonyms or anonymous contributions are allowed.)

We use the Probot DCO GitHub app to check for DCO signoffs of every commit.

If you forget to sign your commits, the DCO bot will remind you and give you detailed instructions for how to amend your commits to add a signature.

License

This Reaction plugin is GNU GPLv3 Licensed

api-plugin-carts's Issues

add peerDependency for account plugin

Carts uses the Address type in GraphQL, which lives in the accounts plugin.

When work is done to move carts over here, we need to be sure to install api-plugin-accounts as a peerDependency.

https://app.circleci.com/pipelines/github/reactioncommerce/reaction/4737/workflows/f3df07a3-61f7-4ea2-bf95-bab57e910596/jobs/69113

imageURLs missing in CartItem

Issue Description

When querying for the images of a cart item, a null value is returned even for items that have images defined.

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue?

Steps to Reproduce

Running the following query for a cart that has an item with images:

query anonymousCartByCartIdQuery(
  $cartId: ID!
  $cartToken: String!
  $itemsAfterCursor: ConnectionCursor
) {
  cart: anonymousCartByCartId(cartId: $cartId, cartToken: $cartToken) {
    items(first: 20, after: $itemsAfterCursor) {
      nodes {
        imageURLs {
          large
          small
          original
          medium
          thumbnail
        }
      }
    }
  }
}

Returns:

{
  "data": {
    "cart": {
      "items": {
        "nodes": [
          {
            "imageURLs": null
          }
        ]
      }
    }
  }
}

Possible Solution

Looking into the code looks like nowhere in the resolvers the imageURLs property is set.
A possible solution is to query the needed media in the CartItem resolver, similar to how it's done in the products plugin.

Versions

4.0.0

ProductConfiguration not provided in anonymousCartByCartId query

Prerequisites

• Are you running the latest version?
• Are you able to consistently reproduce the issue?
• Did you search the issue queue for existing issue? Search issues

Issue Description

When I query the cart for the productConfiguration field, I get this error:

"message": "Cannot return null for non-nullable field CartItem.productConfiguration.",
      "locations": [
        {
          "line": 34,
          "column": 11
        }
      ],
      "path": [
        "anonymousCartByCartId",
        "checkout",
        "fulfillmentGroups",
        0,
        "items",
        0,
        "productConfiguration"
      ],

When checking the plugin, productConfiguration is based on item.productId and item.variantId. Both exist in the database on the CartItem object.

Steps to Reproduce

1. Run the query anonymousCartByCartIdQuery in the playground for an anonymous cart.

Possible Solution

Could be that the fields are not included in the item object when it's getting the data from the mongo collection.

Versions

3.7.1

the possibility to choose several variants as in the case of a color and size variant

If we take the example of a product with two variants color and size, therefore to add product in cart we must select a color in variant colors and a size in variant sizes.

With the structure of the cart we won't be able to do this kind of manipulation.

My Solution

{
  "Cart" : {
     ...
     products: ["productId":....,
"shopId":.....,
"addedAt":....,
"position": ....,
"quantity":.....,
         "items": []
     ]
  }
}

is to group the selection items of each catalog product.

add peerDependency for Tags plugin

Carts uses the TagSortByField and TagConnection type in GraphQL, which lives in the tags plugin.

When work is done to move carts over here, we need to be sure to install api-plugin-tags as a peerDependency.

Cannot extend cart schema

In the transformAndValidateCart mutation the cart schema is loaded directly from file as import { Cart as CartSchema } from "../simpleSchemas.js";. It makes it impossible to extend the cart schema as the validation fails. The schema should be retrieved from the context as follows: const CartSchema = context.simpleSchemas.Cart;

Build fulfillment groups mechanism makes it impossible to build custom groups

Prerequisites

• [ + ] Are you running the latest version?
• [ + ] Are you able to consistently reproduce the issue?
• [ + ] Did you search the issue queue for existing issue? Search issues

Issue Description

Currently every time the cart gets updated (add item, remove item, set shipping address etc) the transformAndValidateCart method is being called, which in turn calls updateCartFulfillmentGroups.
This works well when there is no need to build custom fulfillment groups or allow customer to place cart items in specific groups.
This is because updateCartFulfillmentGroups is destructive, it will iterate over each cart item to determine the group it should belong to based on the supported shipping type. The item ends up being re-allocated even if it was previously assigned to a specific group by the customer or some other underlying mechanism.

Possible Solution

In updateCartFulfillmentGroups determine if the items is already allocated to the group, if so, do not re-allocate.

Versions

2.x, 3.x

Fix anonymousCartByCartId query. Make it accept cartId and anonymous access token.

Issue Description

Discussion in PR #30

Possible Solution

Remove OR condition in DB query. Handle case where anonymousAccessToken is sent hashed and not hashed.

add peerDependency for address-validation plugin

This plugin uses the Address, and AddressInput types in GraphQL, which live in the address-validation plugin.

When work is done to move this plugin, we need to be sure to install api-plugin-address-validation as a peerDependency.