Coder Social home page Coder Social logo

Comments (21)

sarink avatar sarink commented on May 5, 2024 13

Why is this not published yet??

from hooks.

jrwpatterson avatar jrwpatterson commented on May 5, 2024 5

is anybody dealing with this?

from hooks.

zhigang1992 avatar zhigang1992 commented on May 5, 2024 4

For anyone that want to use it right now, you can use this one. ๐Ÿ‘‡

package.json

{
   ...
    "react-navigation-hooks": "npm:@zhigang1992/react-navigation-hooks@latest",
   ...
}

from hooks.

bySabi avatar bySabi commented on May 5, 2024 3

Great!
I hope to have some PR soon.

from hooks.

slorber avatar slorber commented on May 5, 2024 3

I merged the PR here and you can get the types starting 1.0.2-alpha.0

from hooks.

slorber avatar slorber commented on May 5, 2024 2

Yep, types are not published:
https://unpkg.com/[email protected]/dist/Hooks.d.ts

we can use types or typings with TS

from hooks.

bySabi avatar bySabi commented on May 5, 2024 1

Created a first PR on typescript environment and tooling only: #10

from hooks.

zaguiini avatar zaguiini commented on May 5, 2024 1

Can confirm that republishing works. It looks like the published version was using another workflow instead of the most recent one, so the types were not being generated/published.

I made a simple test that proves that (note the -test suffix on the package's name):

image

I really just ran yarn publish.

from hooks.

slorber avatar slorber commented on May 5, 2024 1

@brentvatne @satya164 hi, do you have publish access on this repo?

from hooks.

slorber avatar slorber commented on May 5, 2024

Hey, As ReactNavigation will be in typescript (i think?) maybe we should just write this lib in typescript too?

Btw why not use @react-navigation/hooks package name? Is this package different from other navigation packages?

from hooks.

ericvicenti avatar ericvicenti commented on May 5, 2024

TS support would definitely be an appreciated contribution!

The reasoning behind the react-navigation-hooks name is that it is a testing ground for now, before hooks are stable. Once react-nav starts depending on react 16.7+, we can move this to /core.

from hooks.

bySabi avatar bySabi commented on May 5, 2024

@ericvicenti I want to contrib rewriting this package in typescript. I would like to know if there is any problem in upgrade it to babel 7 ?

from hooks.

ericvicenti avatar ericvicenti commented on May 5, 2024

Feel free to upgrade us to babel 7, I think that would be great

from hooks.

bySabi avatar bySabi commented on May 5, 2024

Now is done. Waiting for PR get merged.
I'm planing to add a example repo to.

from hooks.

zaguiini avatar zaguiini commented on May 5, 2024

Can't use it yet. Am I doing something wrong? There's no .d.ts file

from hooks.

kevinwolfcr avatar kevinwolfcr commented on May 5, 2024

@zaguiini this is happening because the property on the package.json should be typings and currently is types. I've created #15 to fix that.

from hooks.

zaguiini avatar zaguiini commented on May 5, 2024

I donโ€™t think so, @kevinwolfcr, because some packages I publish to npm doesnโ€™t have this field too and the typings work. Probably the d.ts files aren't published

from hooks.

slorber avatar slorber commented on May 5, 2024

@ericvicenti could you republish with types? Or share publish right with me or someone else if you are busy? thanks

from hooks.

zaguiini avatar zaguiini commented on May 5, 2024

is anybody dealing with this?

Best you can do right now is to create a declaration file by yourself inside your project...

from hooks.

shamilovtim avatar shamilovtim commented on May 5, 2024

Still need types please!

from hooks.

slorber avatar slorber commented on May 5, 2024

Hi,

Can you try this please?

yarn add [email protected]

I've made a PR to update the TS env to use babel ts plugin through Bob. It's not yet merged yet (because I have a problem setting up jest/tests) but still made a release so that people here can try the ts types.

#27

from hooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.