useFocusEffect should handle drawers about hooks

[satya164]

A screen being in focus basically means that it's the currently active screen. Opening a drawer doesn't change the active screen, the screen is still active even if its behind the drawer (and drawer is not a screen), so it has a semantically different meaning. So what you have seems alright to me.

In v1, drawer was treated like a screen which caused more trouble than it was worth.

In v5 drawer has drawerOpen and drawerClose events which you can listen and build a useDrawerOpenEffect or something like that on top of it. I wanted to add these events in v4, but changing anything in the event system turned out to be a lot of work.

[slorber]

Can you show the original code? Le jeu. 12 déc. 2019 à 21:42, Sibelius Seraphini <[email protected]> a écrit :

…

useFocusEffect will be called on Drawer everytime the app navigates to another route I've fixed like this: useEffect(() => { if (navigation.state.isDrawerOpen) { // handle navigation is open } }, [navigation.state?.isDrawerOpen]); — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55?email_source=notifications&email_token=AAFW6PV7LBUK5W5CNAGBVITQYKO2PA5CNFSM4J2ED72KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IAFB6TA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFW6PQ3O2DT2DTHLBDDUHLQYKO2PANCNFSM4J2ED72A> .

[sibelius]

useFocusEffect(useCallback(() => {
    // handle drawer is open
  }, []));

[sibelius]

tks for the explanation

I think I can live well with useEffect and navigation.state?.isDrawerOpen for now