Coder Social home page Coder Social logo

Comments (7)

satya164 avatar satya164 commented on May 5, 2024

We're throwing an error in navigation ex. I think it's more confusing for the user to give undefined instead of a proper error.

from hooks.

satya164 avatar satya164 commented on May 5, 2024

The lint rule won't allow it, but I wonder what's wrong with having it in try catch. The order if hooks should still hold true

from hooks.

slorber avatar slorber commented on May 5, 2024

Honestly I'd find it more easy to handle with useNavigation({optional: true}) or something, would require less boilerplate for people wanting to use this (I do), and we can create TS overloaded functions to return navigation | undefined

from hooks.

satya164 avatar satya164 commented on May 5, 2024

idk, it seems to be a very specific use case. I'd rather export NavigationContext for advanced cases so users can access it with useContext(NavigationContext) if they don't want an error thrown for incorrect usage.

from hooks.

slorber avatar slorber commented on May 5, 2024

Yes that would do the job too :) don't know why I didn't think of that 👍

from hooks.

slorber avatar slorber commented on May 5, 2024

Will be fixed by #38, going to merge/release soon

from hooks.

slorber avatar slorber commented on May 5, 2024

should be fixed by release 1.0.3 and #38, please tell me if everything works

from hooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.