rdeaton / spyral Goto Github PK

on_enter()
Called by the director when this scene is exiting.

on_exit()
Called by the director when this scene is about to run.

In scene.Director.run() there is a line if self._stack > 0:, but self._stack is a list and a list is always greater than an integer (due to a rather unfortunate feature of Python that compares type names alphabetically). It should be just if self._stack:. There are also some checks like if len(self._stack) > 0: -- these are better written as if self._stack: too, or even replaced with a try: except: block.

The spyral.camera.Camera.__init__() and a couple of other methods there use an ['all'] list as a default value for layers. That value is initialized at the moment of the method's definition, and then the same instance of the list is used by all instances of the camera. That means that if I add or remove something to the Camera.layers, all cameras will be affected.

When running the skel.py from the examples directory, I get the following error:

Traceback (most recent call last):
  File "skel.py", line 50, in <module>
    spyral.director.push(Game()) # push means that this Game() instance is
  File "skel.py", line 27, in __init__
    self.camera.set_background(bg)
  File "/.../spyral/camera.py", line 116, in set_background
    raise RuntimeError("Background initialization must be done in a scene's on_enter, not __init__")
RuntimeError: Background initialization must be done in a scene's on_enter, not __init__