rbieber / jspcompressor Goto Github PK

hi,
i have enabled debug true ,
to check whether JSP file compression happening or not.
Please find below debug line for one of the file.

[jspcompressor] Original Size: 10070, reduced to 10070 (0%)
[jspcompressor] Compressing: $("#billingAddressphone").keypress(function(b){var a=b.keyCode||b.which;if(a===13){$("#button2").click();}});$("#addressphone").keypress(function(b){var a=b.keyCode||b.which;if(a===13){$("#button3").click();}});$(document).ready(function(){$("#button2").click(function(){var a=isFieldValueValid("billingAddressphone","N");if(a){var b=$("#myContextPath").val()+"/checkout/getAddressforPhone";$("#billingAddressphoneLabel").hide();$("#checkoutForm").attr("method","post");$("#billingAddresstownCity").attr("disabled",false);$("#checkoutForm").attr("action",b);document.getElementById("retAddrButtonCheck").value="billing";$("#checkoutForm").submit();}else{$("#billingAddressphoneLabel").show();}});});
[jspcompressor] Returning <script type="text/javascript">$("#billingAddressphone").keypress(function(c){var d=c.keyCode||c.which;if(d===13){$("#button2").click();}});$("#addressphone").keypress(function(c){var d=c.keyCode||c.which;if(d===13){$("#button3").click();}});$(document).ready(function(){$("#button2").click(function(){var d=isFieldValueValid("billingAddressphone","N");if(d){var c=$("#myContextPath").val()+"/checkout/getAddressforPhone";$("#billingAddressphoneLabel").hide();$("#checkoutForm").attr("method","post");$("#billingAddresstownCity").attr("disabled",false);$("#checkoutForm").attr("action",c);document.getElementById("retAddrButtonCheck").value="billing";$("#checkoutForm").submit();}else{$("#billingAddressphoneLabel").show();}});});</script>

Looks like compression on happening and showing 0%
My ANT task is

The command line utility is not updated to reflect new options for use with JSP files.

We could probably get much better javascript compression using the Closure compiler. Need to investigate this.

The custom tag library not updated to reflect new options for use.

JSP is getting too compressed and it needs to insure the page directive is on its own line. Example:

<% page ...%>

<div>hi</div>

turns would turn into this:

<% page ... %><div>hi</div>

This breaks when tomcat attempts to load and execute the page as the page directive must be on its own line.

I have compressed my jsps and js files using jsp and yui compressor. My js files are compressed without any errors. But my jsp has gone under lot of change. There are many places where following changes have occured.

[ " is replaced with dot .

Thanks
Abhishek
[email protected]

The velocity tags are not updated to reflect new options for use.

In instances where Javascript is surrounded by , the new HTML comment removal code I put in was stripping all javascript out between them. We need to match these characters FIRST and substitute them with everything in between those comments. THEN do general HTML comment removal.