ramv / node-elastical Goto Github PK

When trying to use Client#putRiver with the latest npm module (0.0.12), the command fails without error message.

The reason why it fails is that the Client.putRiver method is created by the wrapIndexMethod function (https://github.com/ramv/node-elastical/blob/master/lib/client.js#L1052) which removes the first argument from the given function.

This results in Index.putRiver called without the name parameter, because it is sliced off by the wrapIndexMethod implementation.

The arguments to putRiver are (name, config, callback), which when called becomes Index#putRiver(client, config, callback) instead of the intended Index#putRiver(client, name, config, callback).

It's really great that you have extensive docs... except it's impossible to read them unless I clone the repo and run them locally. Which I generally don't want to in the heat of working on a small change to my ES code. Just putting them on Github pages and linking to them from the README would make them much more accessible.

I'd like access to submit a pull request which updates all of the Client documentation links since half of them lead to 404's

I have been including elastical in my project with no problem this week. Now during the install process of my project or when i try to install elastical on its own i get the following npm error:

npm ERR! Error: No compatible version found: diff@'[email protected]'
npm ERR! Valid install targets:
npm ERR! ["1.0.0","1.0.1","1.0.2","1.0.3","1.0.4","1.0.5","1.0.6","1.0.7","1.0.8"]

Would like to have the option to specify an _id when creating an index.

The input could match the following:

client.index('index', 'type', 'my_id', {
     key1:"value 1",
     key2:"value 2"
}, function (err, res) {
    // `err` is an Error, or `null` on success.
    // `res` is the parsed ElasticSearch response data.
    if(err) {
        console.log(err);
    } else {
        console.log(res);
    }
});

The version on npm is quite outdated compared to master .. any chance to push the next version or is master deemed unstable ? I was specifically looking for aliases which have been added just AFTER the current version was published ... they at least look stable to me...

BTW: good library so far!

I see there is a docs folder but it's not viewable unless you clone and open in a browser. Why not host it on gh-pages?

Currently mongoose and node-mysql support this so why not ES?

This would replace (optionally)

{
  "host": "elastic.test.com",
  "port": 9200,
  "index": "production"
}

with this (elastic can be replaced with something better)

elastic://elastic.test.com:9200/production

Following the syntax they use here by setting an existing id and wrapping the change in a {"doc": { ... }} object just replaces the existing document with a doc object now

any way of specifying the TTL through this api?