ramonesteban78 / rockmvvmforms Goto Github PK

We need to prepare a plugin or just add an IoC like Autofac.

This is because the DependencyService of Forms is not testable from a nUnit Library project as it needs to Init Forms to make use of it.

These could cause the following additional implementations:

• We can no longer use the constructors of the ViewModels to pass parameters. We have to find another way. Maybe in the InitAsync function?.

I will prepare this feature asap.

We need an Init() function to avoid access to IViewFactory interface in the App.cs
Also the registration of Views and ViewModels should be made maybe through a RockMvvmForms.Register or something like that.

Say Rock if you would like to have this improve :)

What about adding a method like this without actually creating the instance right away. It would be on hold until requested with Get<T> and it would improve performance in the case we register lot of things.
It could be something like:

Register<T>(Func<T> createAction) { }
RockServiceLocator.Current.Register<Ball>(() => new Ball());

That would also allow us to use concrete instances:

var ball = new Ball(param1, param2);
RockServiceLocator.Current.Register<Ball>(() => ball);

But that would affect how your locator works, because right now everything you register is interpreted as a Singleton. So, to handle this situation I would implement an API like the following:

Register<T, TImpl>(); // a new instance will be created with every Get<T>();
Register<T>(Func<T> instanceFunc); // instanceFunc will be invoked with every Get<T>();
RegisterSingleton<T, TImpl>(); // same as your current Register<T, Timpl>();
RegisterLazySingleton<T>(Func<T> instanceFunc); // instanceFunc will be invoked just once and the result is saved for later use