Coder Social home page Coder Social logo

Comments (4)

byroot avatar byroot commented on June 7, 2024 2

Backported to 7.2 and 7.1.

from rails.

rafaelfranca avatar rafaelfranca commented on June 7, 2024

@byroot

from rails.

byroot avatar byroot commented on June 7, 2024

But I'm unsure of the implications of this.

I think you are correct. I checked the original implementation of this in Paquito, seems like we had this problem all the way down to there.

I think the best fix would be association_cached?(reflection.name) && association(reflection.name).loaded?, so that we don't build association objects needlessly. But other than that your suggestion looks good to me.

from rails.

benk-gc avatar benk-gc commented on June 7, 2024

Nice, thanks for the quick fix!

from rails.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.