rahulsom / lgtmin

Say 'Looks good to me' with pictures

LGTMin

The code powering LGTM.in

What

LGTM is the most popular comment on Github, perhaps. But LGTM is boring. So we spice it up with some images.

Why

Crafting images and picking them works fine on a leisurely day, but at crunch time, it helps to crowdsource your LGTMs.

Running

• Checkout code.
• Install gradle
• Run

gradle appengineRun

Contributing

• Send a Pull Request.
• Check status on Travis (link below).
• Wait for any reviewers to LGTM your code. (Very meta)
• Wait for your code to be merged.

---

lgtmin's Issues

Need Logo for the App

It's ironic that this app has bees supplying images to github repos, and doesn't have it's own logo and favicon. The current one is the default from gaelyk.

Why are GitHub permissions needed?

Lately, LGTM.in requests permissons at GitHub:

Why is that? Can this be avoided?

Add support to browse beyond the front page

Please, consider having images served with SSL

There are some free SSL entities out there. https://letsencrypt.org is one of them.

LGTM.in is not working on enterprise/hosted versions of GitHub right now because it is HTTP only.

Cache and proxy images.

• My employer has blocked quickmeme.
• Also image sizes need to be optimized to improve performance.
• Caching will ensure images are not downloaded over and over by browsers. Not so much about bandwidth as about performance.

Publish analytics on app.

Certificate has expired

renew is needed!

Validate inputs

Small percentage of submissions are non image urls.

Investigate session for bookmarklet

Need a way to gather accurate analytics on new/returning users.

mp4 support

What do you think of supporting mp4 URL ?
MP4 file is much smaller than animated gif.
I implemented in my Mac client app just for fun. https://github.com/toshi0383/LGTM/pull/70

The problem is that GitHub is currently not supporting video tags at all.
But I believe they will soon or later.

Site is down & dead

I know the site was left for dead, but did nobody pick it up?
I might be interested if no one else is. : )
I would just like to know some additional details about it first though too.

What are credits?

The UI is extremely confusing. What are "credits", and why is the icon a money bag?

Based on the proximity to up/down votes, I'd guess it's a strange name for sum of up/down votes, but it seems really weird that all the best "LGTM" images have negative credits while all the completely random, unrelated gifs have positive credits...

Support Curated Lists

Kickass idea by @danveloper

1%-3% of /g requests end with Contention

java.util.ConcurrentModificationException: too much contention on these datastore entities. please try again.
    at com.google.appengine.api.datastore.DatastoreApiHelper.translateError(DatastoreApiHelper.java:36)
    at com.google.appengine.api.datastore.DatastoreApiHelper$1.convertException(DatastoreApiHelper.java:70)
    at com.google.appengine.api.utils.FutureWrapper.get(FutureWrapper.java:94)
    at com.google.appengine.api.utils.FutureWrapper.get(FutureWrapper.java:86)
    at com.google.appengine.api.utils.FutureWrapper.get(FutureWrapper.java:86)
    at com.google.appengine.api.utils.FutureWrapper.get(FutureWrapper.java:86)
    at com.google.appengine.api.datastore.FutureHelper.getInternal(FutureHelper.java:71)
    at com.google.appengine.api.datastore.FutureHelper.quietGet(FutureHelper.java:32)
    at com.google.appengine.api.datastore.TransactionImpl.commit(TransactionImpl.java:115)
    at groovyx.gaelyk.extensions.DatastoreExtensions.withTransaction(DatastoreExtensions.groovy:344)
    at groovyx.gaelyk.extensions.DatastoreExtensions.withTransaction(DatastoreExtensions.groovy:319)
    at sun.reflect.GeneratedMethodAccessor62.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:45)
    at org.codehaus.groovy.runtime.metaclass.ReflectionMetaMethod.invoke(ReflectionMetaMethod.java:51)
    at org.codehaus.groovy.runtime.metaclass.NewInstanceMetaMethod.invoke(NewInstanceMetaMethod.java:54)
    at org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoMetaMethodSiteNoUnwrapNoCoerce.invoke(PojoMetaMethodSite.java:271)
    at org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite.call(PojoMetaMethodSite.java:53)
    at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:116)
    at random.run(random.groovy:19)
    at groovyx.gaelyk.GaelykServlet.runPrecompiled(GaelykServlet.groovy:161)
    at groovyx.gaelyk.GaelykServlet.doService(GaelykServlet.groovy:112)
    at groovyx.gaelyk.GaelykServlet.service(GaelykServlet.groovy:87)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1166)
    at javax.servlet.FilterChain$doFilter.call(Unknown Source)
    at groovyx.gaelyk.routes.RoutesFilter.doFilter(RoutesFilter.groovy:185)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
    at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
    at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
    at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
    at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
    at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:327)
    at org.mortbay.jetty.servlet.Dispatcher.forward(Dispatcher.java:126)
    at groovyx.gaelyk.cache.CacheHandler.serve(CacheHandler.groovy:88)
    at groovyx.gaelyk.cache.CacheHandler$serve.call(Unknown Source)
    at groovyx.gaelyk.routes.RoutesFilter.doFilter(RoutesFilter.groovy:169)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1157)
    at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388)
    at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
    at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
    at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765)
    at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418)
    at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
    at org.mortbay.jetty.Server.handle(Server.java:326)
    at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
    at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:923)
    at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
    at com.google.tracing.TraceContext$TraceContextRunnable.runInContext(TraceContext.java:437)
    at com.google.tracing.TraceContext$TraceContextRunnable$1.run(TraceContext.java:444)
    at com.google.tracing.CurrentContext.runInContext(CurrentContext.java:188)
    at com.google.tracing.TraceContext$AbstractTraceContextCallback.runInInheritedContextNoUnref(TraceContext.java:308)
    at com.google.tracing.TraceContext$AbstractTraceContextCallback.runInInheritedContext(TraceContext.java:300)
    at com.google.tracing.TraceContext$TraceContextRunnable.run(TraceContext.java:441)
    at java.lang.Thread.run(Thread.java:724)

Options:

• Sharding - https://developers.google.com/appengine/articles/sharding_counters
• Pull Queues

Don't redirect from https to http when serving the GIF

This causes mixed content issues and means LGTM GIFs don't get shown in some browsers if the site uses the block-all-mixed-content flag

[Ask] Can I use the logo of lgtmin in my project ?

Hi 😄

I created this repository,
this is very easy project, a plugin for franz.

It only do to open the page of lgtm.in .

---

I want to use the logo of lgtm.in,
but I couldn't find the license about the logo.

Can I use the logo of lgtm.in in my project ? 🤔

---

And sorry for ask this AS ISSUE 😭

Unable to click into videos + scroll bar

On My List I am unable to click through on videos. The images seem to work fine though.

There's also a scrollbar showing in the containers for the videos

Implement Github authentication

The idea is to restrict boothgrabbing of votes. One vote per user per lgtm seems optimal. Anonymity for submissions still seems like a good idea.

markdown code not working on github.com

for example

server is slow af.

Any chance you can run on a faster server/ bigger instance? Let me know if I can help. I use this daily and would love to contribute.

LGTM.in is down

http://lgtm.in/ is down 😢

I hope http://lgtm.in/ will back

Thank you.