rahul-r5 / korakaagaz Goto Github PK

currently, ConsoleLogger checks if a console exists using null == System.console()
while this is fine, it could be made better

System.console returns true only if both input and output streams are present. Console logger requires only an output stream to be present
System.console method also fails inside IDEs because Eclipse Console View is not identified by Java as a valid Console object (a related discussion can be found at this Stack Overflow question)

https://stackoverflow.com/questions/2833853/create-whole-path-automatically-when-writing-to-a-new-file

currently, we have a enabledLogLevelsList List passed to the constructors of File and Console Loggers that contains info regarding enabling/disabling log levels in console and file loggers

there is also a safety check that checks whether this variable is actually a null object or not
this is actually not necessary as the constructor is passed atleast an empty list
one could also add a check for empty list

Exception occurs in openFile, line 202 of FIleLogger. Change the exception checking to check for null in System.out instead.

Log level list is empty since default values are being loaded into it, suggesting XML parsing is not correct

current location: $HOME/.config/.log
new location: $HOME/.config/KoraKaagaz/.log

Log:
Exception in thread "main" java.lang.ClassCastException: class com.sun.xml.internal.stream.events.StartElementEvent cannot be cast to class javax.xml.stream.events.Characters (com.sun.xml.internal.stream.events.StartElementEvent and javax.xml.stream.events.Characters are in module java.xml of loader 'bootstrap')
at java.xml/com.sun.xml.internal.stream.events.DummyEvent.asCharacters(DummyEvent.java:115)
at korakaagaz/infrastructure.validation.logger.LoggerManager.configFileToParse(LoggerManager.java:123)
at korakaagaz/infrastructure.validation.logger.LoggerManager.(LoggerManager.java:66)
at korakaagaz/infrastructure.validation.logger.LoggerFactory.getLoggerInstance(LoggerFactory.java:33)
at korakaagaz/infrastructure.validation.testing.TestHarness.runByName(TestHarness.java:324)
at korakaagaz/infrastructure.validation.testing.runner.main(runner.java:8)

Test harness and logger is the environment. The test harness is initialised by a main function. The exception occurs when the test harness tries to get a logger instance.

The file logger doesn't seem to add newlines to its log messages and leads to not so good output
This is probably because it uses printf instead of println