radarsu / validate-polish Goto Github PK

Hello,
I have noticed that in version 2.0.34 there was added month and day validation.
Unfortunately, it does not take into account the fact that in PESEL there is a century encoded in the month digits.
Basically, there is a possibility that month digits > 12, for all people born after 2000.

Example: PESEL 00320506835 returns false.
See https://en.wikipedia.org/wiki/PESEL for the algo.

Other than that - great job, thanks.

This pesel 71122506585 is recognized as valid regon. Regex for length shoud be 9 or 14 digits not range between {9, 14}

Hi @radarsu, I've noticed that this library does not explicitly state what license does it use, however according to package.json it is supposed to be GPL-3.0 licensed. This license makes this library essentially useless for any larger project (commercial or not, except for GPL-licensed project obviously), because GPL is considered to be a viral license, forcing the code which uses it (in most cases) to also be licensed using GPL.

Would you consider relicensing your library to a more permissive license, eg. MIT, Apache or BSD-3-clause? Conversely, if this was not your intention to license it as GPL-3.0 (IANAL, but currently your code does not include the required copy of the GPL license), could you please include the desired license text and also update the package.json accordingly?

Hi @radarsu! I have noticed that pesel validation has bug. If you validate pesel - 55558888888, it's gonna return true. Please make sure that pesel validation is checking also date because there is no 88th day of the month.
Cheers.