Comments (10)
I think that was changed in #22 but not sure what the minimum version should be. Using v12 here.
from chef-slack_handler.
We've definitely released the changes in #22.
from chef-slack_handler.
Chef 12.x is about 1.5 years old, so I've only been testing on it. It wouldn't surprise me if there was something broken in Chef 11.x. I'd be happy to merge PRs to add compatibility back, if so. 👍
from chef-slack_handler.
i was investigating this, and i fixed it locally by saving run_context
from report()
locally as @run_context
, instead of "asking" it from chef internals. this also involved moving @util
creation to report
method.
would you accept such rewrite as PR?
from chef-slack_handler.
@glensc Would you consider building a branch that exercises the issue? I'd like to understand further what's happening here. The chef run_context object was definitely around in Chef 11.x.
from chef-slack_handler.
yes, but not in exact place you're taking it now. and i feel it's using it's internal structures is unreliable. and storing it as instance property @run_context
makes rest of the code also more readable (don't need to pass it around between methods)
ok, i'll try to clean it up and show the branch, but that tomorrow, hopefully.
from chef-slack_handler.
This is currently blocking me from using chef-slack_handler with Chef v11.12.4
from chef-slack_handler.
Thanks @glensc. I actually arrived at almost the same solution before seeing your commit 😄
from chef-slack_handler.
💃
from chef-slack_handler.
closing as #35 was merged
from chef-slack_handler.
Related Issues (20)
- webhook triggered on success with fail_only=true HOT 2
- icon_url config not read in slack_handler_webhook.rb
- Support webhook default configuration from Slack UI HOT 4
- Add support for cookbook context HOT 2
- default['chef_client']['handler']['slack']['fail_only'] is ignored when using webhooks HOT 5
- Add support for deployment start message HOT 7
- `channel` listed as optional but slackr requires it HOT 2
- Add support for environment HOT 5
- At latest version problems when changing message_detail_level from basic to other HOT 4
- why-run mode not working when using this cookbook HOT 1
- Integrating Slack Handler into client.rb? HOT 5
- no implicit conversion of Chef::DelayedEvaluator into String HOT 6
- WARN: Failed to send message to Slack: undefined local variable or method `run_context' for #<SlackHandlerUtil:0x00000001d8e1d0> HOT 11
- better handling of webhook messages with encoding problems
- Initial run fails due to missing /var/chef/handlers directory HOT 1
- NameError: uninitialized constant Chef::Handler::Slack HOT 1
- chef_handler 3.0 breaks it HOT 2
- Handler does not alert on custom exceptions HOT 3
- Ridley error when uploading cookbook
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chef-slack_handler.