Coder Social home page Coder Social logo

Comments (10)

cknowles avatar cknowles commented on August 19, 2024

I think that was changed in #22 but not sure what the minimum version should be. Using v12 here.

from chef-slack_handler.

martinb3 avatar martinb3 commented on August 19, 2024

We've definitely released the changes in #22.

from chef-slack_handler.

martinb3 avatar martinb3 commented on August 19, 2024

Chef 12.x is about 1.5 years old, so I've only been testing on it. It wouldn't surprise me if there was something broken in Chef 11.x. I'd be happy to merge PRs to add compatibility back, if so. 👍

from chef-slack_handler.

glensc avatar glensc commented on August 19, 2024

i was investigating this, and i fixed it locally by saving run_context from report() locally as @run_context, instead of "asking" it from chef internals. this also involved moving @util creation to report method.

would you accept such rewrite as PR?

from chef-slack_handler.

martinb3 avatar martinb3 commented on August 19, 2024

@glensc Would you consider building a branch that exercises the issue? I'd like to understand further what's happening here. The chef run_context object was definitely around in Chef 11.x.

from chef-slack_handler.

glensc avatar glensc commented on August 19, 2024

yes, but not in exact place you're taking it now. and i feel it's using it's internal structures is unreliable. and storing it as instance property @run_context makes rest of the code also more readable (don't need to pass it around between methods)

ok, i'll try to clean it up and show the branch, but that tomorrow, hopefully.

from chef-slack_handler.

kjwierenga avatar kjwierenga commented on August 19, 2024

This is currently blocking me from using chef-slack_handler with Chef v11.12.4

from chef-slack_handler.

kjwierenga avatar kjwierenga commented on August 19, 2024

Thanks @glensc. I actually arrived at almost the same solution before seeing your commit 😄

from chef-slack_handler.

glensc avatar glensc commented on August 19, 2024

💃

from chef-slack_handler.

glensc avatar glensc commented on August 19, 2024

closing as #35 was merged

from chef-slack_handler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.