Coder Social home page Coder Social logo

Comments (4)

nicwaller avatar nicwaller commented on July 19, 2024

I agree that it would be preferable to be able to use the icon and username defined in the Slack integration, rather than always overriding it.

But it's not enough to fix this in initialize. If the username isn't set to a sane default then it will be nil, and the resultant JSON sent to Slack will look like this.

{
  "username": null,
  "etc": "etc"
}

So the request_body def needs to be patched too, because that's where the JSON request gets built. If config[:username] is nil, it shouldn't be included in the request at all.

from chef-slack_handler.

cknowles avatar cknowles commented on July 19, 2024

Just working on a pull request for this.

from chef-slack_handler.

cknowles avatar cknowles commented on July 19, 2024

This actually works with null username by the way, Slack still uses the default set on its side if null is submitted. Will patch it anyway.

from chef-slack_handler.

martinb3 avatar martinb3 commented on July 19, 2024

Fixed in #19.

from chef-slack_handler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.